Re: [PATCH v2] power: max17042_battery: add HEALTH and TEMP_* properties support

From: Sebastian Reichel <sre@kernel.org>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: "Pallala, Ramakrishna" <ramakrishna.pallala@intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	MyungJoo Ham <myungjoo.ham@samsung.com>
Subject: Re: [PATCH v2] power: max17042_battery: add HEALTH and TEMP_* properties support
Date: Mon, 27 Jul 2015 03:22:36 +0200	[thread overview]
Message-ID: <20150727012235.GA24229@earth> (raw)
In-Reply-To: <55B57C85.4070309@samsung.com>

[-- Attachment #1: Type: text/plain, Size: 905 bytes --]

Hi,

On Mon, Jul 27, 2015 at 09:34:13AM +0900, Krzysztof Kozlowski wrote:
>>> [...]
>>
>> I missed this email (may be overlooked it). To have the
>> interrupts enabled we need the config registers(0x1Dh) bit's
>> BIT(9), BIT(4) and BIT92) should be 1 and  BIT(8) should be 0.
>> 
>> Can you dump the status(00h), Talrt(02H) Temp(08h) and
>> config(1Dh) registers values and share?
> 
> Thanks for responding. The issue was in BIT(8) which was set to default
> value of 0x1. This would mean to use external sensor but the board does
> not have it.
> 
> This is a DT platform and there is no initial config data so all
> registers are set to default values.
> 
> Anyway everything seems to work as expected, thanks for explanation.

So I guess the bit should be set to 0 during probe. Maybe with a
boolean DT property "maxim,has-external-sensor" for setting it
to 1.

-- Sebastian

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]