Re: [PATCH 1/2] drm/edid: Use ARRAY_SIZE in drm_add_modes_noedid

From: Daniel Vetter <daniel@ffwll.ch>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
	Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
	DRI Development <dri-devel@lists.freedesktop.org>,
	Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH 1/2] drm/edid: Use ARRAY_SIZE in drm_add_modes_noedid
Date: Mon, 10 Aug 2015 14:08:27 +0200	[thread overview]
Message-ID: <20150810120827.GY17734@phenom.ffwll.local> (raw)
In-Reply-To: <20150810115720.GX1262@ulmo.nvidia.com>

On Mon, Aug 10, 2015 at 01:57:21PM +0200, Thierry Reding wrote:
> On Mon, Aug 10, 2015 at 11:55:37AM +0200, Daniel Vetter wrote:
> > Spotted while reading code for random reasons.
> > 
> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> > ---
> >  drivers/gpu/drm/drm_edid.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
> > index 4a403eb90ded..4780b1924bef 100644
> > --- a/drivers/gpu/drm/drm_edid.c
> > +++ b/drivers/gpu/drm/drm_edid.c
> > @@ -3810,7 +3810,7 @@ int drm_add_modes_noedid(struct drm_connector *connector,
> >  	struct drm_display_mode *mode;
> >  	struct drm_device *dev = connector->dev;
> >  
> > -	count = sizeof(drm_dmt_modes) / sizeof(struct drm_display_mode);
> > +	count = ARRAY_SIZE(drm_dmt_modes);
> >  	if (hdisplay < 0)
> >  		hdisplay = 0;
> >  	if (vdisplay < 0)
> 
> 
> Reviewed-by: Thierry Reding <treding@nvidia.com>

Thanks for the review, applied to drm-misc.
-Danie
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx