Re: [PATCH v2] ASoC: ics43432: Add codec driver for InvenSense ICS-43432

From: Mark Brown <broonie@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	Ricard Wanderlof <ricard.wanderlof@axis.com>,
	Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH v2] ASoC: ics43432: Add codec driver for InvenSense ICS-43432
Date: Mon, 17 Aug 2015 10:33:17 -0700	[thread overview]
Message-ID: <20150817173317.GQ10748@sirena.org.uk> (raw)
In-Reply-To: <55D191BB.1000204@metafoo.de>

[-- Attachment #1.1: Type: text/plain, Size: 750 bytes --]

On Mon, Aug 17, 2015 at 09:48:11AM +0200, Lars-Peter Clausen wrote:

> Yes, I was. In my opinion this set_dai_fmt() implementation is useful to
> have as a mechanism to detect invalid configurations. E.g. if you don't
> implement the callback the CODEC will accept any setting while with he
> callback it will error out with the wrong configuration. Given that a I2S
> link typically at least somewhat works, even if you have the wrong setting,
> I think it makes sense to keep it to catch errors early on.

I agree that it's useful to catch such errors however I don't want to go
to implementing basically empty functions if we don't have to - we
should add the ability to specify capabilites in the DAI for the core to
check instead. 

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]