All of lore.kernel.org
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Christian Hartmann <cornogle@googlemail.com>
Cc: alsa-devel@alsa-project.org,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	Haojian Zhuang <haojian.zhuang@gmail.com>,
	linux-spi@vger.kernel.org, Mark Brown <broonie@kernel.org>,
	jarkko.nikula@linux.intel.com, Daniel Mack <daniel@zonque.org>,
	Robert Jarzmik <robert.jarzmik@free.fr>,
	dan.carpenter@oracle.com
Subject: Re: Fwd: [PATCH 1/1] SPI : spi-pxa2xx : fix spi init of WM510205 codec via ACPI (resend)
Date: Mon, 24 Aug 2015 09:51:40 +0100	[thread overview]
Message-ID: <20150824085140.GA5647@ck-lbox> (raw)
In-Reply-To: <CAKor6TeJp4ti6_QVCEpz0x7c2NwvUiS5wq_=_WDjM3B7T4=1Yg@mail.gmail.com>

On Fri, Aug 21, 2015 at 02:09:46PM +0200, Christian Hartmann wrote:
> Hi
> 
> 2015-08-21 9:43 GMT+02:00 Mika Westerberg <mika.westerberg@linux.intel.com>:
> > So please drop the code in 1) to be able to request the GPIO in the
> > driver.
> 
> [    6.129664] spi spi-WM510205:00: 8333333 Hz actual, PIO
> [    6.129675] spi spi-WM510205:00: setup mode 0, 8 bits/w, 8000000 Hz max --> 0
> [    6.129759] spi spi-WM510205:00: checking WM510205 with bmp180
> [    6.129765] spi spi-WM510205:00: checking WM510205 with bmp181
> [    6.129797] spi spi-WM510205:00: modalias WM510205 in id_table not
> found, returns NULL
> [    6.129825] arizona spi-WM510205:00: arizona_acpi_get_type(), than
> via spi_get_device_id().
> [    6.129831] arizona spi-WM510205:00: arizona_acpi_get_type matched
> [    6.129836] arizona spi-WM510205:00: using 1 as type for arizona audio codec
> [    6.129840] arizona spi-WM510205:00: regmap set to wm5102_spi
> [    6.130630] arizona spi-WM510205:00: spi_irq = -1
> [    6.130638] arizona spi-WM510205:00: acpi_dev_add_driver_gpios
> [    6.144806] arizona spi-WM510205:00: found device ID: ffff
> [    6.175352] arizona spi-WM510205:00: Unknown device ID ffff
> [    6.175584] pxa2xx-spi 80860F0E:00: registered child spi-WM510205:00
> [    6.177870] sst-acpi 80860F28:00: No matching ASoC machine driver found
> 
> as you said, I removed the code in 1) so the EBUSY error is gone.
> 
> What is with the spi_irq = -1 ?? is this a problem here?

The IRQ needs pulled from the ACPI as well, having no IRQ
specified will not interfer with basic functionality of the
driver but will become a problem eventually.

Thanks,
Charles

  parent reply	other threads:[~2015-08-24  8:51 UTC|newest]

Thread overview: 79+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAKor6TfKws63jh6f3VzyYpmTffL4-DHWDTdJ6GSgDC08C5W=8w@mail.gmail.com>
     [not found] ` <20150625073618.GH827@lahna.fi.intel.com>
     [not found]   ` <20150625073618.GH827-3PARRvDOhMZrdx17CPfAsdBPR1lH4CV8@public.gmane.org>
2015-06-25 12:18     ` Fwd: [alsa-devel] [PATCH 1/1] SPI : spi-pxa2xx : fix spi init of WM510205 codec via ACPI (resend) Christian Hartmann
     [not found]       ` <CAKor6TfxNW6UW6iX_FkRn2yZOHvdRHcsj6pKoKH-UWU51Bqvvg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-06-25 14:01         ` Mika Westerberg
2015-06-25 14:58         ` Mark Brown
     [not found]           ` <20150625145853.GP14071-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-06-25 15:44             ` Charles Keepax
     [not found]               ` <20150625154407.GE6321-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2015-06-25 15:56                 ` Mark Brown
     [not found]                   ` <20150625155612.GS14071-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-06-25 16:11                     ` Charles Keepax
     [not found]                       ` <20150625161108.GF6321-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2015-06-29  9:44                         ` Mark Brown
2015-06-29  8:12                     ` Christian Hartmann
     [not found]                       ` <CAKor6TdZNTLnhxpruqDxe4nQsDL+e6xgVHOtVdz4LuFisKNsoQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-06-29  8:35                         ` Charles Keepax
2015-06-26 11:46                 ` [alsa-devel] Fwd: " Pierre-Louis Bossart
     [not found]                   ` <558D3BAA.3080700-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-06-26 11:58                     ` Mark Brown
     [not found]                       ` <20150626115823.GY14071-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-06-29  7:27                         ` Christian Hartmann
     [not found]                           ` <CAKor6Tf20eC1WQSO=AV2b+XoB5Qv-2Oin_nrrTJUiDV4czxLjA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-06-29  7:46                             ` Christian Hartmann
     [not found]                               ` <CAKor6TdzzAqG1yNtqkWftdvNo8_bxC=qnU+60rgiM=38qrJ2yQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-06-29 10:22                                 ` Mark Brown
2015-06-29  9:48                             ` Mark Brown
     [not found]                               ` <20150629094854.GB11162-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-06-30  7:14                                 ` Christian Hartmann
     [not found]                                   ` <CAKor6TdDPb2qOgdHbeX2w+yQa_ioDM5ak9bk+=jF+cKt_twiXw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-06-30  9:25                                     ` Mark Brown
2015-06-30 10:34                                     ` Charles Keepax
     [not found]                                       ` <20150630103404.GI6321-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2015-07-07  7:06                                         ` Christian Hartmann
     [not found]                                           ` <CAKor6TdKk2OUz4o12RiQBSVZyhD=L4JpBJcYkGE=_6X+ZeQY_g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-07-07  9:56                                             ` Charles Keepax
     [not found]                                               ` <20150707095613.GG16517-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2015-07-07 11:40                                                 ` Mark Brown
2015-07-07 12:16                                             ` Charles Keepax
2015-07-13  9:53                                             ` Charles Keepax
     [not found]                                               ` <20150713095359.GM16517-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2015-07-15  7:01                                                 ` Christian Hartmann
     [not found]                                                   ` <CAKor6Td83zgOS+iHGHGhFW4n26H=tC-QQDuzaHHfybhLeH-jvw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-07-15  7:17                                                     ` Christian Hartmann
     [not found]                                                       ` <CAKor6TdheYM73aqti362bOnP2GZmX60uuDY5v2eow1vqO9tcKw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-07-15  8:12                                                         ` Charles Keepax
     [not found]                                                           ` <20150715081224.GN16517-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2015-07-15  9:17                                                             ` Mark Brown
     [not found]                                                               ` <20150715091709.GK11162-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-07-17  6:56                                                                 ` Christian Hartmann
2015-07-17  7:11                                                                   ` Christian Hartmann
     [not found]                                                                   ` <CAKor6TcSc7n=Rd9NJAf-6cYXr50Z62cbcsbuaEutRMPAiM=2NQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-07-17  8:54                                                                     ` [alsa-devel] " Charles Keepax
2015-08-10  7:00                                                                       ` Christian Hartmann
     [not found]                                                                         ` <CAKor6Tcof3PA3JGD2=4X8mtSak8ka9BVD2L4zdYC4M1yEYEXjg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-08-10  7:53                                                                           ` [alsa-devel] " Charles Keepax
2015-08-10  8:00                                                                         ` Christian Hartmann
     [not found]                                                                           ` <CAKor6TdLkGZbARmV1CfqUiguH8HAD+oC8VSsH_OkNQ6E-7YVAw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-08-10  8:10                                                                             ` [alsa-devel] " Charles Keepax
2015-08-10  8:35                                                                               ` Mika Westerberg
     [not found]                                                                                 ` <20150810083540.GE1540-3PARRvDOhMZrdx17CPfAsdBPR1lH4CV8@public.gmane.org>
2015-08-10  9:20                                                                                   ` [alsa-devel] " Christian Hartmann
     [not found]                                                                                     ` <CAKor6TfZC3AY0p-85mFAUJJYQ360NoDu6AppipSqAD73S_EkzQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-08-10  9:26                                                                                       ` Mika Westerberg
     [not found]                                                                                         ` <20150810092632.GA1541-3PARRvDOhMZrdx17CPfAsdBPR1lH4CV8@public.gmane.org>
2015-08-10 12:43                                                                                           ` Christian Hartmann
2015-08-10 13:48                                                                                   ` Christian Hartmann
     [not found]                                                                                     ` <CAKor6Tc26kKG-7ytxBjT41S1h4eORoeTg_T=nZ4dZGM1H0gAMQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-08-10 14:02                                                                                       ` Mika Westerberg
     [not found]                                                                                         ` <20150810140207.GB1541-3PARRvDOhMZrdx17CPfAsdBPR1lH4CV8@public.gmane.org>
2015-08-14 10:08                                                                                           ` Christian Hartmann
     [not found]                                                                                             ` <CAKor6TdKrQrvXTPU=fzL9LTCBbyc9WAbLnYdObY+Wu73g1w6Fg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-08-19 10:29                                                                                               ` Christian Hartmann
     [not found]                                                                                                 ` <CAKor6Tep1jjOnoPn7e5Djird3RVDNP8Gjcb8HOKO6g-_R5++VQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-08-19 13:43                                                                                                   ` Mika Westerberg
     [not found]                                                                                                     ` <20150819134328.GU1552-3PARRvDOhMZrdx17CPfAsdBPR1lH4CV8@public.gmane.org>
2015-08-20  9:38                                                                                                       ` Christian Hartmann
     [not found]                                                                                                         ` <CAKor6Tc6RDW+2uuX2yMszk3O69=6QTPdd+emC-m_Cro67VPR8g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-08-20  9:45                                                                                                           ` Mika Westerberg
     [not found]                                                                                                             ` <20150820094542.GC30005-3PARRvDOhMZrdx17CPfAsdBPR1lH4CV8@public.gmane.org>
2015-08-20 11:34                                                                                                               ` Christian Hartmann
     [not found]                                                                                                                 ` <CAKor6Te-DSDxx711-EQi=fw46nNPGnQNqhj-+6upBxhOOp5XvA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-08-20 11:52                                                                                                                   ` Christian Hartmann
2015-08-20 11:58                                                                                                                   ` Mika Westerberg
     [not found]                                                                                                                     ` <20150820115845.GF30005-3PARRvDOhMZrdx17CPfAsdBPR1lH4CV8@public.gmane.org>
2015-08-21  7:31                                                                                                                       ` Christian Hartmann
     [not found]                                                                                                                         ` <CAKor6Teq=Aoa6WYkTEVpjBPsWziL-o5FzQHxJWOMeaTrMzXpMg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-08-21  7:43                                                                                                                           ` Mika Westerberg
     [not found]                                                                                                                             ` <20150821074310.GM30005-3PARRvDOhMZrdx17CPfAsdBPR1lH4CV8@public.gmane.org>
2015-08-21 12:09                                                                                                                               ` Christian Hartmann
     [not found]                                                                                                                                 ` <CAKor6TeJp4ti6_QVCEpz0x7c2NwvUiS5wq_=_WDjM3B7T4=1Yg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-08-21 12:33                                                                                                                                   ` Christian Hartmann
2015-08-24  8:51                                                                                                                                 ` Charles Keepax [this message]
2015-08-24 13:25                                                                                                                                   ` Christian Hartmann
     [not found]                                                                                                                                     ` <CAKor6TcRWgn-Z+Va0JKCBqxVA9HBSLMR_vh-z8MSBZebn9kDVg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-08-25  6:21                                                                                                                                       ` [alsa-devel] " Mark Brown
     [not found]                                                                                                                                         ` <20150825062157.GB27431-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-08-26  8:47                                                                                                                                           ` Christian Hartmann
     [not found]                                                                                                                                             ` <CAKor6Tf_8J4DVrVRShw2ked-zJzmP6G1P1i=vTcbzWX-J1H6dQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-08-26  8:58                                                                                                                                               ` Christian Hartmann
2015-08-26  9:13                                                                                                                                                 ` Charles Keepax
2015-08-28  7:22                                                                                                                                                   ` [alsa-devel] " Christian Hartmann
     [not found]                                                                                                                                                 ` <CAKor6TfpWuhTG6dfARdHmXEb+bLpm5Q6Z-A0g60VPD2fCWHbOg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-08-26 10:01                                                                                                                                                   ` Mika Westerberg
     [not found]                                                                                                                                                     ` <20150826100155.GA1513-3PARRvDOhMZrdx17CPfAsdBPR1lH4CV8@public.gmane.org>
2015-08-27 11:44                                                                                                                                                       ` Christian Hartmann
2015-08-27 11:59                                                                                                                                                         ` Mika Westerberg
     [not found]                                                                                                                                                           ` <20150827115914.GF28428-3PARRvDOhMZrdx17CPfAsdBPR1lH4CV8@public.gmane.org>
2015-08-27 14:56                                                                                                                                                             ` [alsa-devel] " Mark Brown
     [not found]                                                                                                                                                               ` <20150827145614.GC5313-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-08-28  9:00                                                                                                                                                                 ` Mika Westerberg
2015-08-28  9:07                                                                                                                                                                   ` Richard Fitzgerald
     [not found]                                                                                                                                                                     ` <1440752855.25096.3.camel-WeElTRBN8n0bEPBeyYQi64iQ8/zYDDdY1BehtkLrGTY@public.gmane.org>
2015-08-28  9:12                                                                                                                                                                       ` [alsa-devel] " Mika Westerberg
     [not found]                                                                                                                                                                   ` <20150828090042.GI28428-3PARRvDOhMZrdx17CPfAsdBPR1lH4CV8@public.gmane.org>
2015-08-28  9:16                                                                                                                                                                     ` Mark Brown
     [not found]                                                                                                                                                               ` <CAKor6Tf8kB0WPXLTBFmCzUJkMVEDu-xTEyw0-_NZvBdFSyQSFA@mail.gmail.com>
     [not found]                                                                                                                                                                 ` <CAKor6Tf8kB0WPXLTBFmCzUJkMVEDu-xTEyw0-_NZvBdFSyQSFA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-08-28  9:50                                                                                                                                                                   ` Fwd: " Christian Hartmann
     [not found]                                                                                                                                                                     ` <CAKor6TfW4reRz3m-xkCr_ZUfHQkfqT3q+S7JCpO-9F+k1QW38g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-09-01  9:45                                                                                                                                                                       ` Christian Hartmann
     [not found]                                                                                                                                                                         ` <CAKor6Tf7_Hiyc1v_TGvdVAU+G84Gp+KgKeSGi8EQJRoq9rhMuw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-09-02  8:13                                                                                                                                                                           ` Charles Keepax
2015-09-02  8:13                                                                                                                                                                             ` Charles Keepax
2015-09-04 13:32                                                                                                                                                                             ` Christian Hartmann
2015-09-04 14:34                                                                                                                                                                               ` Charles Keepax
     [not found]                                                                                                                                                                                 ` <20150904143434.GA1514-ARjQNJ2nNhTg0ogRn3sK4gTTu0opVTaCmpATvIKMPHk@public.gmane.org>
2015-09-07  7:58                                                                                                                                                                                   ` [alsa-devel] " Christian Hartmann
     [not found]                                                                                                                                                                                     ` <CAKor6TfhaHfqkmz-dogJ6dEUe06QFv-ee7uPOLiEGSTh3ibkhQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-09-28  9:08                                                                                                                                                                                       ` Charles Keepax
2015-09-28  9:08                                                                                                                                                                                         ` Charles Keepax
2015-09-29  7:48                                                                                                                                                                                         ` Christian Hartmann
2015-09-29  7:57                                                                                                                                                                                           ` Charles Keepax
2015-10-05 10:54                                                                                                                                                                                             ` Christian Hartmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150824085140.GA5647@ck-lbox \
    --to=ckeepax@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=cornogle@googlemail.com \
    --cc=dan.carpenter@oracle.com \
    --cc=daniel@zonque.org \
    --cc=haojian.zhuang@gmail.com \
    --cc=jarkko.nikula@linux.intel.com \
    --cc=linux-spi@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=robert.jarzmik@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.