From: "J. Bruce Fields" <bfields@fieldses.org>
To: Andreas Gruenbacher <agruenba@redhat.com>
Cc: Andreas Gruenbacher <andreas.gruenbacher@gmail.com>,
linux-kernel@vger.kernel.org,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
linux-nfs@vger.kernel.org, linux-api@vger.kernel.org,
linux-cifs@vger.kernel.org,
linux-security-module@vger.kernel.org
Subject: Re: [RFC v6 02/40] vfs: Add MAY_CREATE_FILE and MAY_CREATE_DIR permission flags
Date: Wed, 2 Sep 2015 15:20:08 -0400 [thread overview]
Message-ID: <20150902192008.GB3319@fieldses.org> (raw)
In-Reply-To: <CAHc6FU62LQ8xnEbjsBprnud36AURg_ggifFoHOVM51-9vRJeDg@mail.gmail.com>
On Wed, Sep 02, 2015 at 09:06:32PM +0200, Andreas Gruenbacher wrote:
> 2015-09-02 20:53 GMT+02:00 J. Bruce Fields <bfields@fieldses.org>:
> >> @@ -453,7 +453,8 @@ static int sb_permission(struct super_block *sb, struct inode *inode, int mask)
> >> * this, letting us set arbitrary permissions for filesystem access without
> >> * changing the "normal" UIDs which are used for other things.
> >> *
> >> - * When checking for MAY_APPEND, MAY_WRITE must also be set in @mask.
> >> + * When checking for MAY_APPEND, MAY_CREATE_FILE, MAY_CREATE_DIR,
> >> + * MAY_WRITE must also be set in @mask.
> >
> > Why?
>
> So that file systems that don't support MAY_APPEND can ignore the flag
> and will then automatically check for MAY_WRITE instead.
Got it. And maybe it should be obvious, but it might be worth a
sentence in the changelog if it's not already explained elsewhere.--b.
>
> > (Also: written as a simple list like that, it's a ambiguous how to
> > parse that comment: I think you mean that MAY_WRITE must be set whenever
> > MAY_APPEND, MAY_CREATE_FILE, or MAY_CREATE_DIR are set.)
>
> Yes, that's better.
>
> Thanks,
> Andreas
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-09-02 19:20 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-04 11:52 [RFC v6 00/40] Richacls Andreas Gruenbacher
2015-08-04 11:52 ` Andreas Gruenbacher
2015-08-04 11:52 ` [RFC v6 01/40] vfs: Add IS_ACL() and IS_RICHACL() tests Andreas Gruenbacher
[not found] ` <1438689218-6921-2-git-send-email-agruenba-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-08-28 20:34 ` J. Bruce Fields
2015-08-28 20:34 ` J. Bruce Fields
2015-08-04 11:53 ` [RFC v6 02/40] vfs: Add MAY_CREATE_FILE and MAY_CREATE_DIR permission flags Andreas Gruenbacher
[not found] ` <1438689218-6921-3-git-send-email-agruenba-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-09-02 18:53 ` J. Bruce Fields
2015-09-02 18:53 ` J. Bruce Fields
[not found] ` <20150902185300.GA3319-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2015-09-02 19:06 ` Andreas Gruenbacher
2015-09-02 19:06 ` Andreas Gruenbacher
2015-09-02 19:20 ` J. Bruce Fields [this message]
[not found] ` <20150902192008.GB3319-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2015-09-02 20:23 ` Andreas Gruenbacher
2015-09-02 20:23 ` Andreas Gruenbacher
2015-08-04 11:53 ` [RFC v6 03/40] vfs: Add MAY_DELETE_SELF and MAY_DELETE_CHILD " Andreas Gruenbacher
2015-08-28 20:44 ` J. Bruce Fields
[not found] ` <20150828204413.GB23326-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2015-08-28 21:08 ` Andreas Gruenbacher
2015-08-28 21:08 ` Andreas Gruenbacher
[not found] ` <1438689218-6921-4-git-send-email-agruenba-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-08-28 21:36 ` Andy Lutomirski
2015-08-28 21:36 ` Andy Lutomirski
[not found] ` <CALCETrUoBnPyEGExpoDzHOCgnHh5=a1ROALmb63LLJZG+L=aQA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-08-28 21:54 ` Andreas Grünbacher
2015-08-28 21:54 ` Andreas Grünbacher
2015-08-29 1:04 ` Andy Lutomirski
2015-08-28 21:57 ` J. Bruce Fields
2015-08-28 21:57 ` J. Bruce Fields
2015-08-04 11:53 ` [RFC v6 04/40] vfs: Make the inode passed to inode_change_ok non-const Andreas Gruenbacher
2015-08-04 11:53 ` [RFC v6 05/40] vfs: Add permission flags for setting file attributes Andreas Gruenbacher
2015-08-04 11:53 ` [RFC v6 06/40] richacl: In-memory representation and helper functions Andreas Gruenbacher
[not found] ` <1438689218-6921-1-git-send-email-agruenba-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-08-04 11:53 ` [RFC v6 07/40] richacl: Permission mapping functions Andreas Gruenbacher
2015-08-04 11:53 ` Andreas Gruenbacher
2015-08-04 11:53 ` [RFC v6 08/40] richacl: Compute maximum file masks from an acl Andreas Gruenbacher
2015-08-04 11:53 ` Andreas Gruenbacher
[not found] ` <1438689218-6921-9-git-send-email-agruenba-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-09-02 19:54 ` J. Bruce Fields
2015-09-02 19:54 ` J. Bruce Fields
[not found] ` <20150902195408.GC3319-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2015-09-02 19:54 ` J. Bruce Fields
2015-09-02 19:54 ` J. Bruce Fields
2015-09-02 20:38 ` Andreas Gruenbacher
2015-09-02 20:38 ` Andreas Gruenbacher
2015-08-04 11:53 ` [RFC v6 18/40] ext4: Add richacl support Andreas Gruenbacher
2015-08-04 11:53 ` Andreas Gruenbacher
2015-08-04 11:53 ` [RFC v6 23/40] richacl: Set the owner permissions to the owner mask Andreas Gruenbacher
2015-08-04 11:53 ` Andreas Gruenbacher
2015-08-04 11:53 ` [RFC v6 30/40] nfsd: Add richacl support Andreas Gruenbacher
2015-08-04 11:53 ` Andreas Gruenbacher
2015-08-04 11:53 ` [RFC v6 34/40] ext4: Don't allow unmapped identifiers in richacls Andreas Gruenbacher
2015-08-04 11:53 ` Andreas Gruenbacher
2015-08-04 11:53 ` [RFC v6 39/40] nfs: Add richacl support Andreas Gruenbacher
2015-08-04 11:53 ` Andreas Gruenbacher
2015-08-04 11:53 ` [RFC v6 40/40] nfs: Add support for the v4.1 dacl attribute Andreas Gruenbacher
2015-08-04 11:53 ` Andreas Gruenbacher
2015-08-04 11:53 ` [RFC v6 09/40] richacl: Update the file masks in chmod() Andreas Gruenbacher
[not found] ` <1438689218-6921-10-git-send-email-agruenba-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-09-01 21:38 ` J. Bruce Fields
2015-09-01 21:38 ` J. Bruce Fields
[not found] ` <20150901213816.GH10468-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2015-09-02 6:08 ` Andreas Grünbacher
2015-09-02 6:08 ` Andreas Grünbacher
2015-08-04 11:53 ` [RFC v6 10/40] richacl: Permission check algorithm Andreas Gruenbacher
[not found] ` <1438689218-6921-11-git-send-email-agruenba-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-08-28 21:49 ` J. Bruce Fields
2015-08-28 21:49 ` J. Bruce Fields
2015-08-28 22:06 ` Andreas Grünbacher
[not found] ` <CAHpGcMJT0kQyrvCkur0csCmRn-LwUOJcRWqAfLaqCpNd2b8UXA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-08-31 15:23 ` J. Bruce Fields
2015-08-31 15:23 ` J. Bruce Fields
2015-08-04 11:53 ` [RFC v6 11/40] vfs: Cache base_acl objects in inodes Andreas Gruenbacher
2015-08-04 11:53 ` [RFC v6 12/40] vfs: Cache richacl in struct inode Andreas Gruenbacher
2015-08-04 11:53 ` [RFC v6 13/40] richacl: Check if an acl is equivalent to a file mode Andreas Gruenbacher
2015-08-04 11:53 ` [RFC v6 14/40] richacl: Create-time inheritance Andreas Gruenbacher
2015-08-04 11:53 ` [RFC v6 15/40] richacl: Automatic Inheritance Andreas Gruenbacher
2015-08-04 11:53 ` [RFC v6 16/40] richacl: xattr mapping functions Andreas Gruenbacher
2015-08-04 11:53 ` [RFC v6 17/40] vfs: Add richacl permission checking Andreas Gruenbacher
2015-08-04 11:53 ` [RFC v6 19/40] ext4: Add richacl feature flag Andreas Gruenbacher
2015-08-04 11:53 ` [RFC v6 20/40] richacl: acl editing helper functions Andreas Gruenbacher
2015-08-04 11:53 ` [RFC v6 21/40] richacl: Move everyone@ aces down the acl Andreas Gruenbacher
2015-08-04 11:53 ` [RFC v6 22/40] richacl: Propagate everyone@ permissions to other aces Andreas Gruenbacher
2015-08-04 11:53 ` [RFC v6 24/40] richacl: Set the other permissions to the other mask Andreas Gruenbacher
2015-08-04 11:53 ` [RFC v6 25/40] richacl: Isolate the owner and group classes Andreas Gruenbacher
2015-08-04 11:53 ` [RFC v6 26/40] richacl: Apply the file masks to a richacl Andreas Gruenbacher
2015-08-04 11:53 ` [RFC v6 27/40] richacl: Create richacl from mode values Andreas Gruenbacher
2015-08-04 11:53 ` [RFC v6 28/40] nfsd: Keep list of acls to dispose of in compoundargs Andreas Gruenbacher
2015-08-04 11:53 ` [RFC v6 29/40] nfsd: Use richacls as internal acl representation Andreas Gruenbacher
2015-08-04 11:53 ` [RFC v6 31/40] nfsd: Add support for the v4.1 dacl attribute Andreas Gruenbacher
2015-08-04 11:53 ` [RFC v6 32/40] nfsd: Add support for the MAY_CREATE_{FILE,DIR} permissions Andreas Gruenbacher
2015-08-04 11:53 ` [RFC v6 33/40] richacl: Add support for unmapped identifiers Andreas Gruenbacher
2015-08-04 11:53 ` [RFC v6 35/40] sunrpc: Allow to demand-allocate pages to encode into Andreas Gruenbacher
2015-08-04 11:53 ` [RFC v6 36/40] sunrpc: Add xdr_init_encode_pages Andreas Gruenbacher
2015-08-04 11:53 ` [RFC v6 37/40] nfs: Fix GETATTR bitmap verification Andreas Gruenbacher
2015-08-04 11:53 ` [RFC v6 38/40] nfs: Remove unused xdr page offsets in getacl/setacl arguments Andreas Gruenbacher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150902192008.GB3319@fieldses.org \
--to=bfields@fieldses.org \
--cc=agruenba@redhat.com \
--cc=andreas.gruenbacher@gmail.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.