Re: [PATCH] drm/atomic-helper: Add option to update planes only on active crtc

From: Thierry Reding <treding@nvidia.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
	Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
	Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
	DRI Development <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] drm/atomic-helper: Add option to update planes only on active crtc
Date: Tue, 8 Sep 2015 13:10:58 +0200	[thread overview]
Message-ID: <20150908111056.GA31658@ulmo.nvidia.com> (raw)
In-Reply-To: <1441706527-22048-1-git-send-email-daniel.vetter@ffwll.ch>


[-- Attachment #1.1: Type: text/plain, Size: 2075 bytes --]

On Tue, Sep 08, 2015 at 12:02:07PM +0200, Daniel Vetter wrote:
> With drivers supporting runtime pm it's generally not a good idea to
> touch the hardware when it's off. Add an option to the commit_planes
> helper to support this case.
> 
> Note that the helpers already add all planes on a crtc when a modeset
> happens, hence plane updates will not be lost if drivers set this to
> true.
> 
> v2: Check for NULL state->crtc before chasing the pointer. Also check
> both old and new crtc if there's a switch. Finally just outright
> disallow switching crtcs for a plane if the plane is in active use, on
> most hardware that doesn't make sense.
> 
> v3: Since commit_planes(active_only = true) is for enabling things
> only after all the crtc are on we should only look at the new crtc to
> decide whether to call the plane hooks - if the current CRTC isn't on
> then skip. If the old crtc (when moving a plane) went down then the
> plane should have been disabled as part of the pipe shutdown work
> already. For which there's currently no helper really unfortunately.
> Also move the check for wether a plane gets a new CRTC assigned while
> still in active use out of this patch.
> 
> v4: Rebase over exynos changes.
> 
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Thierry Reding <treding@nvidia.com>
> Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
>  drivers/gpu/drm/drm_atomic_helper.c     | 20 ++++++++++++++++++--
>  drivers/gpu/drm/exynos/exynos_drm_drv.c |  2 +-
>  drivers/gpu/drm/msm/msm_atomic.c        |  2 +-
>  drivers/gpu/drm/omapdrm/omap_drv.c      |  2 +-
>  drivers/gpu/drm/rcar-du/rcar_du_kms.c   |  2 +-
>  drivers/gpu/drm/sti/sti_drv.c           |  2 +-
>  drivers/gpu/drm/tegra/drm.c             |  2 +-
>  include/drm/drm_atomic_helper.h         |  3 ++-
>  8 files changed, 26 insertions(+), 9 deletions(-)

Reviewed-by: Thierry Reding <treding@nvidia.com>
Tested-by: Thierry Reding <treding@nvidia.com>

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel