From: Chris Wilson <chris@chris-wilson.co.uk>
To: ankitprasad.r.sharma@intel.com
Cc: intel-gfx@lists.freedesktop.org, akash.goel@intel.com,
shashidhar.hiremath@intel.com
Subject: Re: [PATCH 5/5] drm/i915: Propagating correct error codes to the userspace
Date: Wed, 23 Sep 2015 12:32:02 +0100 [thread overview]
Message-ID: <20150923113202.GA6739@nuc-i3427.alporthouse.com> (raw)
In-Reply-To: <1443005483-4481-6-git-send-email-ankitprasad.r.sharma@intel.com>
On Wed, Sep 23, 2015 at 04:21:23PM +0530, ankitprasad.r.sharma@intel.com wrote:
> From: Ankitprasad Sharma <ankitprasad.r.sharma@intel.com>
>
> Propagating correct error codes to userspace by using ERR_PTR and
> PTR_ERR macros for stolen memory based object allocation. We generally
> return -ENOMEM to the user whenever there is a failure in object
> allocation. This patch helps user to identify the correct reason for the
> failure and not just -ENOMEM each time.
This should be done before patch 3, so that the error progation is in
place before adding the possible EINTR.
Also note that the current i915_gem_object_alloc() itself can return
more than just ENOMEM and is worth expanding the possible error returns
as well.
Otherwise, lgtm.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-09-23 11:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-23 10:51 [PATCH v7 0/5] Support for creating/using Stolen memory backed objects ankitprasad.r.sharma
2015-09-23 10:51 ` [PATCH 1/5] drm/i915: Clearing buffer objects via CPU/GTT ankitprasad.r.sharma
2015-09-23 10:51 ` [PATCH 2/5] drm/i915: Support for creating Stolen memory backed objects ankitprasad.r.sharma
2015-09-23 10:51 ` [PATCH 3/5] drm/i915: Add support for stealing purgable stolen pages ankitprasad.r.sharma
2015-09-23 11:42 ` Chris Wilson
2015-09-23 10:51 ` [PATCH 4/5] drm/i915: Support for pread/pwrite from/to non shmem backed objects ankitprasad.r.sharma
2015-09-23 11:50 ` Chris Wilson
2015-09-23 10:51 ` [PATCH 5/5] drm/i915: Propagating correct error codes to the userspace ankitprasad.r.sharma
2015-09-23 11:32 ` Chris Wilson [this message]
2015-09-23 13:14 ` [PATCH] drm/i915: Propagate error from drm_gem_object_init() Chris Wilson
2015-09-23 16:03 ` [PATCH v7 0/5] Support for creating/using Stolen memory backed objects Daniel Vetter
2015-09-23 16:14 ` Chris Wilson
2015-09-23 16:19 ` Chris Wilson
2015-09-23 17:09 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150923113202.GA6739@nuc-i3427.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=akash.goel@intel.com \
--cc=ankitprasad.r.sharma@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=shashidhar.hiremath@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.