From: kbuild test robot <lkp@intel.com>
Cc: kbuild-all@01.org, James.Bottomley@HansenPartnership.com,
linux-kernel@vger.kernel.com, devicetree@vger.kernel.org,
arnd@arndb.de, linuxarm@huawei.com, zhangfei.gao@linaro.org,
linux-scsi@vger.kernel.org, xuwei5@hisilicon.com,
john.garry2@mail.dcu.ie, hare@suse.de,
John Garry <john.garry@huawei.com>
Subject: Re: [PATCH 10/25] scsi: hisi_sas: add misc HBA initialization
Date: Tue, 13 Oct 2015 05:44:07 +0800 [thread overview]
Message-ID: <201510130510.nnYDo5fI%fengguang.wu@intel.com> (raw)
In-Reply-To: <1444663237-238302-11-git-send-email-john.garry@huawei.com>
Hi John,
[auto build test WARNING on scsi/for-next -- if it's inappropriate base, please suggest rules for selecting the more suitable base]
url: https://github.com/0day-ci/linux/commits/John-Garry/HiSilicon-SAS-driver/20151012-231929
reproduce:
# apt-get install sparse
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__
sparse warnings: (new ones prefixed by >>)
drivers/scsi/hisi_sas/hisi_sas_init.c:228:5: sparse: symbol 'hisi_sas_ioremap' was not declared. Should it be static?
>> drivers/scsi/hisi_sas/hisi_sas_init.c:318:47: sparse: incorrect type in assignment (different base types)
drivers/scsi/hisi_sas/hisi_sas_init.c:318:47: expected unsigned long long [unsigned] [usertype] dev_sas_addr
drivers/scsi/hisi_sas/hisi_sas_init.c:318:47: got restricted __be64 [usertype] <noident>
vim +318 drivers/scsi/hisi_sas/hisi_sas_init.c
307b867d John Garry 2015-10-12 222 hisi_hba->sata_breakpoint_dma);
ac2334d3 John Garry 2015-10-12 223
ac2334d3 John Garry 2015-10-12 224 if (hisi_hba->wq)
ac2334d3 John Garry 2015-10-12 225 destroy_workqueue(hisi_hba->wq);
307b867d John Garry 2015-10-12 226 }
307b867d John Garry 2015-10-12 227
2b5563f7 John Garry 2015-10-12 @228 int hisi_sas_ioremap(struct hisi_hba *hisi_hba)
2b5563f7 John Garry 2015-10-12 229 {
2b5563f7 John Garry 2015-10-12 230 struct platform_device *pdev = hisi_hba->pdev;
2b5563f7 John Garry 2015-10-12 231 struct device *dev = &pdev->dev;
2b5563f7 John Garry 2015-10-12 232 struct resource *res;
2b5563f7 John Garry 2015-10-12 233
2b5563f7 John Garry 2015-10-12 234 res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
2b5563f7 John Garry 2015-10-12 235 hisi_hba->regs = devm_ioremap(dev,
2b5563f7 John Garry 2015-10-12 236 res->start,
2b5563f7 John Garry 2015-10-12 237 resource_size(res));
2b5563f7 John Garry 2015-10-12 238 if (!hisi_hba->regs)
2b5563f7 John Garry 2015-10-12 239 return -ENOMEM;
2b5563f7 John Garry 2015-10-12 240
2b5563f7 John Garry 2015-10-12 241 res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
2b5563f7 John Garry 2015-10-12 242 hisi_hba->ctrl_regs = devm_ioremap(dev,
2b5563f7 John Garry 2015-10-12 243 res->start,
2b5563f7 John Garry 2015-10-12 244 resource_size(res));
2b5563f7 John Garry 2015-10-12 245 if (!hisi_hba->ctrl_regs)
2b5563f7 John Garry 2015-10-12 246 return -ENOMEM;
2b5563f7 John Garry 2015-10-12 247
2b5563f7 John Garry 2015-10-12 248 return 0;
2b5563f7 John Garry 2015-10-12 249 }
28e5387c John Garry 2015-10-12 250
28e5387c John Garry 2015-10-12 251 static const struct of_device_id sas_of_match[] = {
28e5387c John Garry 2015-10-12 252 { .compatible = "hisilicon,sas-controller-v1",},
28e5387c John Garry 2015-10-12 253 {},
28e5387c John Garry 2015-10-12 254 };
28e5387c John Garry 2015-10-12 255 MODULE_DEVICE_TABLE(of, sas_of_match);
b94d2f2e John Garry 2015-10-12 256
b94d2f2e John Garry 2015-10-12 257 static struct hisi_hba *hisi_sas_hba_alloc(
b94d2f2e John Garry 2015-10-12 258 struct platform_device *pdev,
b94d2f2e John Garry 2015-10-12 259 struct Scsi_Host *shost,
b94d2f2e John Garry 2015-10-12 260 struct device_node *np)
b94d2f2e John Garry 2015-10-12 261 {
b94d2f2e John Garry 2015-10-12 262 int interrupt_count, interrupt_cells;
b94d2f2e John Garry 2015-10-12 263 struct hisi_hba *hisi_hba;
b94d2f2e John Garry 2015-10-12 264
b94d2f2e John Garry 2015-10-12 265 hisi_hba = devm_kzalloc(&pdev->dev, sizeof(*hisi_hba), GFP_KERNEL);
b94d2f2e John Garry 2015-10-12 266 if (!hisi_hba)
b94d2f2e John Garry 2015-10-12 267 goto err_out;
b94d2f2e John Garry 2015-10-12 268
b94d2f2e John Garry 2015-10-12 269 hisi_hba->pdev = pdev;
307b867d John Garry 2015-10-12 270
ac2334d3 John Garry 2015-10-12 271 init_timer(&hisi_hba->timer);
ac2334d3 John Garry 2015-10-12 272
307b867d John Garry 2015-10-12 273 if (of_property_read_u32(np, "phy-count", &hisi_hba->n_phy))
307b867d John Garry 2015-10-12 274 goto err_out;
307b867d John Garry 2015-10-12 275
307b867d John Garry 2015-10-12 276 if (of_property_read_u32(np, "queue-count", &hisi_hba->queue_count))
307b867d John Garry 2015-10-12 277 goto err_out;
307b867d John Garry 2015-10-12 278
307b867d John Garry 2015-10-12 279 if (of_property_read_u32(np, "controller-id", &hisi_hba->id))
307b867d John Garry 2015-10-12 280 goto err_out;
307b867d John Garry 2015-10-12 281
307b867d John Garry 2015-10-12 282 interrupt_count = of_property_count_u32_elems(np, "interrupts");
307b867d John Garry 2015-10-12 283 if (interrupt_count < 0)
307b867d John Garry 2015-10-12 284 goto err_out;
307b867d John Garry 2015-10-12 285
307b867d John Garry 2015-10-12 286 if (of_property_read_u32(np, "#interrupt-cells", &interrupt_cells))
307b867d John Garry 2015-10-12 287 goto err_out;
307b867d John Garry 2015-10-12 288
307b867d John Garry 2015-10-12 289 hisi_hba->int_names = devm_kcalloc(&pdev->dev,
307b867d John Garry 2015-10-12 290 interrupt_count / interrupt_cells,
307b867d John Garry 2015-10-12 291 HISI_SAS_NAME_LEN,
307b867d John Garry 2015-10-12 292 GFP_KERNEL);
307b867d John Garry 2015-10-12 293 if (!hisi_hba->int_names)
307b867d John Garry 2015-10-12 294 goto err_out;
307b867d John Garry 2015-10-12 295
b94d2f2e John Garry 2015-10-12 296 hisi_hba->shost = shost;
b94d2f2e John Garry 2015-10-12 297
2b5563f7 John Garry 2015-10-12 298 if (hisi_sas_ioremap(hisi_hba))
2b5563f7 John Garry 2015-10-12 299 goto err_out;
2b5563f7 John Garry 2015-10-12 300
307b867d John Garry 2015-10-12 301 if (hisi_sas_alloc(hisi_hba, shost)) {
307b867d John Garry 2015-10-12 302 hisi_sas_free(hisi_hba);
307b867d John Garry 2015-10-12 303 goto err_out;
307b867d John Garry 2015-10-12 304 }
307b867d John Garry 2015-10-12 305
b94d2f2e John Garry 2015-10-12 306 return hisi_hba;
b94d2f2e John Garry 2015-10-12 307 err_out:
b94d2f2e John Garry 2015-10-12 308 dev_err(&pdev->dev, "hba alloc failed\n");
b94d2f2e John Garry 2015-10-12 309 return NULL;
b94d2f2e John Garry 2015-10-12 310 }
b94d2f2e John Garry 2015-10-12 311
f6486930 John Garry 2015-10-12 312 static void hisi_sas_init_add(struct hisi_hba *hisi_hba)
f6486930 John Garry 2015-10-12 313 {
f6486930 John Garry 2015-10-12 314 u8 i;
f6486930 John Garry 2015-10-12 315
f6486930 John Garry 2015-10-12 316 /* Huawei IEEE id (001882) */
f6486930 John Garry 2015-10-12 317 for (i = 0; i < hisi_hba->n_phy; i++)
f6486930 John Garry 2015-10-12 @318 hisi_hba->phy[i].dev_sas_addr =
f6486930 John Garry 2015-10-12 319 cpu_to_be64(0x5001882016072015ULL);
f6486930 John Garry 2015-10-12 320
f6486930 John Garry 2015-10-12 321 memcpy(hisi_hba->sas_addr, &hisi_hba->phy[0].dev_sas_addr,
:::::: The code at line 318 was first introduced by commit
:::::: f6486930094e8da780099095ad77e86b3b766008 scsi: hisi_sas: add phy SAS ADDR initialization
:::::: TO: John Garry <john.garry@huawei.com>
:::::: CC: 0day robot <fengguang.wu@intel.com>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
next prev parent reply other threads:[~2015-10-12 21:44 UTC|newest]
Thread overview: 91+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-12 15:20 [PATCH 00/25] HiSilicon SAS driver John Garry
2015-10-12 15:20 ` [PATCH 02/25] devicetree: bindings: scsi: HiSi SAS John Garry
2015-10-16 13:47 ` Rob Herring
[not found] ` <CAL_JsqLk9p_YX2FCNiR4sOSU74asN0UrOSJ5gQfnyRhrFH8LgQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-10-19 10:48 ` John Garry
2015-10-19 14:51 ` zhangfei
2015-10-12 15:20 ` [PATCH 03/25] scsi: hisi_sas: add initial bare driver John Garry
[not found] ` <1444663237-238302-4-git-send-email-john.garry-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2015-10-15 8:49 ` Xinwei Kong
2015-10-15 9:23 ` John Garry
2015-10-15 9:28 ` zhangfei
[not found] ` <561F707C.1070305-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2015-10-15 12:07 ` Xinwei Kong
2015-10-12 15:20 ` [PATCH 04/25] scsi: hisi_sas: add scsi host registration John Garry
2015-10-12 15:21 ` Arnd Bergmann
2015-10-12 15:21 ` Arnd Bergmann
2015-10-13 9:16 ` John Garry
2015-10-13 9:16 ` John Garry
2015-10-13 12:18 ` Arnd Bergmann
2015-10-12 15:20 ` [PATCH 07/25] scsi: hisi_sas: add ioremap for device HW John Garry
2015-10-12 15:21 ` Arnd Bergmann
2015-10-13 9:47 ` zhangfei
2015-10-13 9:47 ` zhangfei
2015-10-13 12:20 ` Arnd Bergmann
2015-10-13 12:20 ` Arnd Bergmann
2015-10-13 15:09 ` zhangfei
2015-10-12 17:18 ` [RFC PATCH] scsi: hisi_sas: hisi_sas_ioremap() can be static kbuild test robot
2015-10-12 17:18 ` [PATCH 07/25] scsi: hisi_sas: add ioremap for device HW kbuild test robot
2015-10-12 15:20 ` [PATCH 08/25] scsi: hisi_sas: add cq structure initialization John Garry
2015-10-12 15:20 ` [PATCH 10/25] scsi: hisi_sas: add misc HBA initialization John Garry
2015-10-12 21:44 ` kbuild test robot [this message]
2015-10-12 15:20 ` [PATCH 12/25] scsi: hisi_sas: add v1 HW initialisation code John Garry
2015-10-12 18:46 ` Arnd Bergmann
2015-10-13 12:44 ` John Garry
2015-10-13 12:44 ` John Garry
2015-10-13 12:47 ` Arnd Bergmann
2015-10-12 15:20 ` [PATCH 13/25] scsi: hisi_sas: add path from phyup irq to SAS framework John Garry
2015-10-12 22:03 ` kbuild test robot
2015-10-13 0:27 ` Julian Calaby
2015-10-13 0:40 ` [lkp] " Fengguang Wu
2015-10-12 22:03 ` [RFC PATCH] scsi: hisi_sas: hisi_sas_bytes_dmaed() can be static kbuild test robot
2015-10-16 12:55 ` [PATCH 13/25] scsi: hisi_sas: add path from phyup irq to SAS framework Arnd Bergmann
2015-10-16 13:29 ` John Garry
2015-10-16 13:29 ` John Garry
2015-10-16 13:36 ` Arnd Bergmann
2015-10-19 14:11 ` John Garry
2015-10-19 14:11 ` John Garry
2015-10-19 14:26 ` Arnd Bergmann
2015-10-19 14:55 ` John Garry
2015-10-19 14:55 ` John Garry
2015-10-20 8:40 ` Arnd Bergmann
2015-10-20 9:09 ` John Garry
2015-10-20 9:09 ` John Garry
[not found] ` <1444663237-238302-1-git-send-email-john.garry-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2015-10-12 15:20 ` [PATCH 01/25] [SCSI] sas: centralise ssp frame information units John Garry
2015-10-12 15:20 ` [PATCH 05/25] scsi: hisi_sas: allocate memories and create pools John Garry
2015-10-12 15:15 ` Arnd Bergmann
2015-10-12 15:15 ` Arnd Bergmann
2015-10-13 9:42 ` zhangfei
[not found] ` <1444663237-238302-6-git-send-email-john.garry-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2015-10-13 1:05 ` kbuild test robot
2015-10-12 15:20 ` [PATCH 06/25] scsi: hisi_sas: add slot init code John Garry
2015-10-12 15:20 ` [PATCH 09/25] scsi: hisi_sas: add phy SAS ADDR initialization John Garry
2015-10-13 6:12 ` Hannes Reinecke
[not found] ` <561CA0CB.5090802-l3A5Bk7waGM@public.gmane.org>
2015-10-13 17:14 ` John Garry
2015-10-14 8:40 ` Hannes Reinecke
[not found] ` <561E1501.2070507-l3A5Bk7waGM@public.gmane.org>
2015-10-14 15:05 ` John Garry
2015-10-14 15:18 ` Arnd Bergmann
2015-10-15 3:36 ` zhangfei
2015-10-15 8:43 ` Arnd Bergmann
2015-10-12 15:20 ` [PATCH 11/25] scsi: hisi_sas: add v1 hardware register definitions John Garry
2015-10-12 15:20 ` [PATCH 14/25] scsi: hisi_sas: add ssp command function John Garry
2015-10-13 1:24 ` kbuild test robot
2015-10-12 15:20 ` [PATCH 20/25] scsi: hisi_sas: add smp protocol support John Garry
2015-10-12 15:20 ` [PATCH 22/25] scsi: hisi_sas: add tmf methods John Garry
2015-10-12 23:02 ` kbuild test robot
[not found] ` <1444663237-238302-23-git-send-email-john.garry-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2015-10-12 23:02 ` [RFC PATCH] scsi: hisi_sas: hisi_sas_find_dev_phyno() can be static kbuild test robot
2015-10-12 15:20 ` [PATCH 23/25] scsi: hisi_sas: add control phy handler John Garry
2015-10-12 15:20 ` [PATCH 15/25] scsi: hisi_sas: add cq interrupt handler John Garry
2015-10-12 22:15 ` kbuild test robot
2015-10-12 15:20 ` [PATCH 16/25] scsi: hisi_sas: add dev_found and port_formed John Garry
2015-10-12 22:35 ` [RFC PATCH] scsi: hisi_sas: hisi_sas_alloc_dev() can be static kbuild test robot
2015-10-12 22:35 ` [PATCH 16/25] scsi: hisi_sas: add dev_found and port_formed kbuild test robot
2015-10-12 15:20 ` [PATCH 17/25] scsi: hisi_sas: add abnormal irq handler John Garry
2015-10-12 15:20 ` [PATCH 18/25] scsi: hisi_sas: add dev_gone and port_deformed John Garry
[not found] ` <1444663237-238302-19-git-send-email-john.garry-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2015-10-12 22:49 ` kbuild test robot
2015-10-12 22:49 ` [RFC PATCH] scsi: hisi_sas: hisi_sas_do_release_task() can be static kbuild test robot
2015-10-12 15:20 ` [PATCH 19/25] scsi: hisi_sas: add bcast interrupt handler John Garry
2015-10-12 15:20 ` [PATCH 21/25] scsi: hisi_sas: add scan finished and start John Garry
2015-10-12 15:20 ` [PATCH 24/25] scsi: hisi_sas: add fatal irq handler John Garry
2015-10-12 15:20 ` [PATCH 25/25] MAINTAINERS: add maintainer for HiSi SAS driver John Garry
2015-10-19 8:47 ` [PATCH 00/25] HiSilicon " John Garry
2015-10-19 8:47 ` John Garry
2015-10-19 8:55 ` Hannes Reinecke
2015-10-19 10:40 ` John Garry
2015-10-19 10:40 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201510130510.nnYDo5fI%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=hare@suse.de \
--cc=john.garry2@mail.dcu.ie \
--cc=john.garry@huawei.com \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.com \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=xuwei5@hisilicon.com \
--cc=zhangfei.gao@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.