Re: [PATCH 07/13] tests/exynos: use XRGB8888 for framebuffer

From: Hyungwon Hwang <human.hwang@samsung.com>
To: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
Cc: linux-samsung-soc@vger.kernel.org,
	dri-devel@lists.freedesktop.org, emil.l.velikov@gmail.com,
	jy0922.shim@samsung.com, gustavo.padovan@collabora.co.uk,
	inki.dae@samsung.com
Subject: Re: [PATCH 07/13] tests/exynos: use XRGB8888 for framebuffer
Date: Fri, 30 Oct 2015 15:41:10 +0900	[thread overview]
Message-ID: <20151030154110.6e458145@hwh-ubuntu> (raw)
In-Reply-To: <1442937302-8211-8-git-send-email-tjakobi@math.uni-bielefeld.de>

On Tue, 22 Sep 2015 17:54:56 +0200
Tobias Jakobi <tjakobi@math.uni-bielefeld.de> wrote:

> This matches the G2D color mode that is used in the entire code.
> The previous (incorrect) RGBA8888 would only work since the
> Exynos mixer did its configuration based on the bpp, and not
> based on the actual pixelformat.
> 
> Signed-off-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
> ---
>  tests/exynos/exynos_fimg2d_test.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/exynos/exynos_fimg2d_test.c
> b/tests/exynos/exynos_fimg2d_test.c index 8794dac..dfb00a0 100644
> --- a/tests/exynos/exynos_fimg2d_test.c
> +++ b/tests/exynos/exynos_fimg2d_test.c
> @@ -675,7 +675,7 @@ int main(int argc, char **argv)
>  	offsets[0] = 0;
>  
>  	ret = drmModeAddFB2(dev->fd, screen_width, screen_height,
> -				DRM_FORMAT_RGBA8888, handles,
> +				DRM_FORMAT_XRGB8888, handles,
>  				pitches, offsets, &fb_id, 0);

Reviewed-by: Hyungwon Hwang <human.hwang@samsung.com>

Nice catch. It's right, if there was no previous setting for source
image color mode. But I think it could be the source image color mode
was set by another application before when this test runs. So I think
the code which sets the source image color mode must be added.

Best regards,
Hyungwon Hwang

>  	if (ret < 0)
>  		goto err_destroy_buffer;