Re: [PATCH 04/19] media: Move struct media_entity_graph definition up

From: Sakari Ailus <sakari.ailus@iki.fi>
To: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Cc: linux-media@vger.kernel.org, laurent.pinchart@ideasonboard.com,
	javier@osg.samsung.com, hverkuil@xs4all.nl
Subject: Re: [PATCH 04/19] media: Move struct media_entity_graph definition up
Date: Sun, 29 Nov 2015 15:07:47 +0200	[thread overview]
Message-ID: <20151129130747.GE17128@valkosipuli.retiisi.org.uk> (raw)
In-Reply-To: <20151103222238.GJ17128@valkosipuli.retiisi.org.uk>

On Wed, Nov 04, 2015 at 12:22:38AM +0200, Sakari Ailus wrote:
> Hi Mauro,
> 
> On Wed, Oct 28, 2015 at 09:36:50AM +0900, Mauro Carvalho Chehab wrote:
> > Em Tue, 27 Oct 2015 01:01:35 +0200
> > Sakari Ailus <sakari.ailus@iki.fi> escreveu:
> > 
> > > It will be needed in struct media_pipeline shortly.
> > > 
> > > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> > 
> > Reviewed-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
> > (but see below)
> > 
> > > ---
> > >  include/media/media-entity.h | 20 ++++++++++----------
> > >  1 file changed, 10 insertions(+), 10 deletions(-)
> > > 
> > > diff --git a/include/media/media-entity.h b/include/media/media-entity.h
> > > index fc54192..dde9a5f 100644
> > > --- a/include/media/media-entity.h
> > > +++ b/include/media/media-entity.h
> > > @@ -87,6 +87,16 @@ struct media_entity_enum {
> > >  	int idx_max;
> > >  };
> > >  
> > > +struct media_entity_graph {
> > 
> > Not a problem on this patch itself, but since you're touching this
> > struct, it would be nice to take the opportunity and document it ;)
> 
> I'll document it in a separate patch on top of the set. Would you be fine
> with that?

Thinking about this, I'll change the patches to include the documentation.
It's better that way, I agree.

-- 
Sakari Ailus
e-mail: sakari.ailus@iki.fi	XMPP: sailus@retiisi.org.uk