Re: [PATCH 06/16] ASoC: Intel: Skylake: Add support for Load/Unload IPCs

From: Mark Brown <broonie@kernel.org>
To: Vinod Koul <vinod.koul@intel.com>
Cc: liam.r.girdwood@linux.intel.com, patches.audio@intel.com,
	alsa-devel@alsa-project.org,
	Dharageswari R <dharageswari.r@intel.com>,
	Jeeja KP <jeeja.kp@intel.com>
Subject: Re: [PATCH 06/16] ASoC: Intel: Skylake: Add support for Load/Unload IPCs
Date: Thu, 3 Dec 2015 00:59:14 +0000	[thread overview]
Message-ID: <20151203005914.GA5727@sirena.org.uk> (raw)
In-Reply-To: <20151202050702.GD1854@localhost>

[-- Attachment #1.1: Type: text/plain, Size: 997 bytes --]

On Wed, Dec 02, 2015 at 10:37:02AM +0530, Vinod Koul wrote:
> On Tue, Dec 01, 2015 at 10:58:54PM +0000, Mark Brown wrote:

> > So the multiple modules are a block of at most 255 16 bit words?  That's
> > a bit surprising - is it really a count of the number of modules or
> > rather the size of the block of data that's being squirted at the DSP?

> Nope, as you would think that does not make sense :)

> So we do not point to module memory here, we are sending IPC saying module
> X, Y and Z are being loaded, data contains the module IDs only. The IDs are
> 16 bits so sizeof(u16) and number of modules pass as arg

> The modules are transfered with Code Loader DMA which invokes this as IPC
> after preparing DMA from Host.

> This way IPC allows us to load One or multiple modules at one shot

Can you please at least put this in the same patch as the user if not
merge it more closely?  This is another of those abstractions that's
really unclear just sitting by itself with no explanation.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]