From: Chris Wilson <chris@chris-wilson.co.uk>
To: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org, miku@iki.fi
Subject: Re: [PATCH 4/4] drm/i915: Check unclaimed access per forcewake domain get/put
Date: Wed, 9 Dec 2015 15:48:51 +0000 [thread overview]
Message-ID: <20151209154851.GF29974@nuc-i3427.alporthouse.com> (raw)
In-Reply-To: <1449673301-6449-4-git-send-email-mika.kuoppala@intel.com>
On Wed, Dec 09, 2015 at 05:01:41PM +0200, Mika Kuoppala wrote:
> We do unclaimed register access check in non mmio_debug mode
> once per write. This adds probability of finding the exact
> sequence where we did the bad access, but also adds burden
> to each write.
>
> As we have mmio_debug available for more fine grained analysis,
> give up some accuracy for the benefit of performance in normal case.
> Do this by doing the unclaimed reg check only once when forcewake
> domains are get.
Still far too often in the normal case.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-12-09 15:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-09 15:01 [PATCH 1/4] drm/i915: Consolidate unclaimed reg detection Mika Kuoppala
2015-12-09 15:01 ` [PATCH 2/4] drm/i915: Introduce intel_uncore_unclaimed_access Mika Kuoppala
2015-12-09 15:15 ` Chris Wilson
2015-12-09 15:01 ` [PATCH 3/4] drm/i915: Detect and clear unclaimed access on resume Mika Kuoppala
2015-12-09 15:07 ` Chris Wilson
2015-12-09 15:13 ` Mika Kuoppala
2015-12-09 15:21 ` Chris Wilson
2015-12-09 15:01 ` [PATCH 4/4] drm/i915: Check unclaimed access per forcewake domain get/put Mika Kuoppala
2015-12-09 15:48 ` Chris Wilson [this message]
2015-12-09 15:47 ` [PATCH 1/4] drm/i915: Consolidate unclaimed reg detection Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151209154851.GF29974@nuc-i3427.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mika.kuoppala@linux.intel.com \
--cc=miku@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.