Re: [PATCH 3/5] drm: Move more framebuffer doc from docbook to kerneldoc

From: Thierry Reding <thierry.reding@gmail.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
	Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
	Thierry Reding <treding@nvidia.com>,
	DRI Development <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 3/5] drm: Move more framebuffer doc from docbook to kerneldoc
Date: Mon, 14 Dec 2015 16:58:13 +0100	[thread overview]
Message-ID: <20151214155813.GC1998@ulmo> (raw)
In-Reply-To: <1449564561-3896-3-git-send-email-daniel.vetter@ffwll.ch>

[-- Attachment #1.1: Type: text/plain, Size: 1320 bytes --]

On Tue, Dec 08, 2015 at 09:49:19AM +0100, Daniel Vetter wrote:
[...]
> @@ -187,6 +189,9 @@ struct drm_framebuffer_funcs {
>  	 * copying the current screen contents to a private buffer and blending
>  	 * between that and the new contents.
>  	 *
> +	 * GEM based drivers should call drm_gem_handle_create() to create the
> +	 * handle.
> +	 *
>  	 * RETURNS:
>  	 *
>  	 * 0 on success or a negative error code on failure.
> @@ -1727,6 +1732,17 @@ struct drm_mode_config_funcs {
>  	 * requested metadata, but most of that is left to the driver. See
>  	 * struct &drm_mode_fb_cmd2 for details.
>  	 *
> +	 * If the parameters are deemed valid and the backing storage objects in
> +	 * the underlying memory manager all exists then the drivers to allocate

"... all exist, then the driver allocates a new &drm_framebuffer structure
..."?

> +	 * a new &drm_framebuffer structure, subclassed to contain
> +	 * driver-specific information (like the internal native buffer object
> +	 * references). It also needs to fill out all relevant metadata, which
> +	 * should by done by calling drm_helper_mode_fill_fb_struct().

"should be done"

> +	 *
> +	 * The initializing is finalized by calling drm_framebuffer_init(),

"The initialization"

Other than that, looks good:

Reviewed-by: Thierry Reding <treding@nvidia.com>

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx