From: Chris Wilson <chris@chris-wilson.co.uk>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH igt 3/9] igt/drv_hangman: Inject a true hang
Date: Wed, 16 Dec 2015 10:37:55 +0000 [thread overview]
Message-ID: <20151216103755.GE6851@nuc-i3427.alporthouse.com> (raw)
In-Reply-To: <20151216090227.GH30437@phenom.ffwll.local>
On Wed, Dec 16, 2015 at 10:02:27AM +0100, Daniel Vetter wrote:
> On Sat, Dec 12, 2015 at 08:02:49PM +0000, Chris Wilson wrote:
> > Wean drv_hangman off the atrocious stop_rings and use a real GPU hang
> > instead.
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>
> Doesn't this kill pre-gen6? Or at least anything where we don't have
> proper hang recovery ... Lack of that is why I've done the original
> stop_rings fun.
Originally, igt_hang_ring required gen >= 5, but since that Ville has
been working hard on getting reset support working for gen3 and gen4,
now we query the kernel as to whether it can reset the device. So by
switching over we lose testing of simulated hangs and recovery code (or
KMS handling during wedged) for gen2.
It is a loss in test coverage, but the benefit is that we can remove the
hang injection code from the kernel. And that is a tradeoff I am willing
to make.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-12-16 10:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-12 20:02 [PATCH igt 1/9] lib: Always double check igt_require_hang_ring() on use Chris Wilson
2015-12-12 20:02 ` [PATCH igt 2/9] lib: Expand igt_hang_ring() to select target context and various options Chris Wilson
2015-12-12 20:02 ` [PATCH igt 3/9] igt/drv_hangman: Inject a true hang Chris Wilson
2015-12-16 9:02 ` Daniel Vetter
2015-12-16 10:37 ` Chris Wilson [this message]
2015-12-16 13:12 ` Ville Syrjälä
2015-12-16 13:51 ` Chris Wilson
2015-12-16 14:03 ` Chris Wilson
2015-12-12 20:02 ` [PATCH igt 4/9] igt/gem_ctx_exec: Convert from stop-rings to a real GPU hang/reset Chris Wilson
2015-12-12 20:02 ` [PATCH igt 5/9] igt/gem_reset_stats: Convert from stop-rings to real hang injection Chris Wilson
2015-12-12 20:02 ` [PATCH igt 6/9] igt/kms_pipe_crc_basic: Replace stop_rings with igt_hang_ring Chris Wilson
2015-12-12 20:02 ` [PATCH igt 7/9] igt/kms_flip: Convert over to real hang injection Chris Wilson
2015-12-12 20:02 ` [PATCH igt 8/9] igt/gem_workarounds: Convert to real GPU " Chris Wilson
2015-12-12 20:02 ` [PATCH igt 9/9] igt/pm_rps: Trigger a real GPU reset Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151216103755.GE6851@nuc-i3427.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.