From: Mark Brown <broonie@kernel.org>
To: Bard Liao <bardliao@realtek.com>
Cc: oder_chiou@realtek.com, alsa-devel@alsa-project.org,
lars@metafoo.de, zhengxing@rock-chips.com, lgirdwood@gmail.com,
john.lin@realtek.com, zhengsq@rock-chips.com, flove@realtek.com
Subject: Re: [PATCH] ASoC: rt5616: add rt5616 codec driver
Date: Sat, 19 Dec 2015 12:01:33 +0000 [thread overview]
Message-ID: <20151219120133.GJ5727@sirena.org.uk> (raw)
In-Reply-To: <1450162661-23186-1-git-send-email-bardliao@realtek.com>
[-- Attachment #1.1: Type: text/plain, Size: 653 bytes --]
On Tue, Dec 15, 2015 at 02:57:41PM +0800, Bard Liao wrote:
A couple of very minor issues with the control names here but otherwise
this looks good - I'll apply this, please send followup patches fixing
these:
> + /* IN1/IN2 Control */
> + SOC_SINGLE_TLV("IN1 Boost", RT5616_IN1_IN2,
> + RT5616_BST_SFT1, 8, 0, bst_tlv),
> + SOC_SINGLE_TLV("IN2 Boost", RT5616_IN1_IN2,
> + RT5616_BST_SFT2, 8, 0, bst_tlv),
These should be " Boost Volume".
> + /* ADC Boost Volume Control */
> + SOC_DOUBLE_TLV("ADC Boost Gain", RT5616_ADC_BST_VOL,
> + RT5616_ADC_L_BST_SFT, RT5616_ADC_R_BST_SFT,
> + 3, 0, adc_bst_tlv),
Boost Volume (like the comments says!).
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2015-12-19 12:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-15 6:57 [PATCH] ASoC: rt5616: add rt5616 codec driver Bard Liao
2015-12-19 12:01 ` Mark Brown [this message]
2015-12-19 12:02 ` Applied "ASoC: rt5616: add rt5616 codec driver" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151219120133.GJ5727@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bardliao@realtek.com \
--cc=flove@realtek.com \
--cc=john.lin@realtek.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=oder_chiou@realtek.com \
--cc=zhengsq@rock-chips.com \
--cc=zhengxing@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.