From: "Daniel P. Berrange" <berrange@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Marcelo Tosatti" <mtosatti@redhat.com>,
qemu-devel@nongnu.org, "Luiz Capitulino" <lcapitulino@redhat.com>,
"Andreas Färber" <andreas.faerber@web.de>
Subject: Re: [Qemu-devel] [PATCH 5/7] qapi: rename input buttons
Date: Tue, 12 Jan 2016 12:49:22 +0000 [thread overview]
Message-ID: <20160112124922.GH17626@redhat.com> (raw)
In-Reply-To: <1452601779-5790-5-git-send-email-kraxel@redhat.com>
On Tue, Jan 12, 2016 at 01:29:37PM +0100, Gerd Hoffmann wrote:
> All lowercase, use-dash instead of CamelCase.
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> hw/input/hid.c | 4 ++--
> hw/input/ps2.c | 4 ++--
> hw/input/virtio-input-hid.c | 4 ++--
> monitor.c | 2 +-
> qapi-schema.json | 5 +----
> qmp-commands.hx | 4 ++--
> ui/cocoa.m | 4 ++--
> ui/gtk.c | 4 ++--
> ui/input-legacy.c | 4 ++--
> ui/sdl.c | 4 ++--
> ui/sdl2.c | 4 ++--
> ui/spice-input.c | 4 ++--
> ui/vnc.c | 4 ++--
> 13 files changed, 24 insertions(+), 27 deletions(-)
Reviewed-by: Daniel P. Berrange <berrange@redhat.com>
> diff --git a/qapi-schema.json b/qapi-schema.json
> index 3884479..511702f 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -3662,12 +3662,9 @@
> # Button of a pointer input device (mouse, tablet).
> #
> # Since: 2.0
> -#
> -# Note that the spelling of these values may change when the
> -# x-input-send-event is promoted out of experimental status.
> ##
> { 'enum' : 'InputButton',
> - 'data' : [ 'Left', 'Middle', 'Right', 'WheelUp', 'WheelDown' ] }
> + 'data' : [ 'left', 'middle', 'right', 'wheel-up', 'wheel-down' ] }
Ok, this rename is safe todo, since this enum is only used from the
experimental x-input-send-event command
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
next prev parent reply other threads:[~2016-01-12 12:49 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-12 12:29 [Qemu-devel] [PATCH 1/7] console: add qemu_console_lookup_by_device_name Gerd Hoffmann
2016-01-12 12:29 ` [Qemu-devel] [PATCH 2/7] console: use qemu_console_lookup_by_device_name in qemu_input_handler_bind Gerd Hoffmann
2016-01-12 12:43 ` Daniel P. Berrange
2016-01-12 12:29 ` [Qemu-devel] [PATCH 3/7] console: use qemu_console_lookup_by_device_name in vnc_display_open Gerd Hoffmann
2016-01-12 12:43 ` Daniel P. Berrange
2016-01-12 12:29 ` [Qemu-devel] [PATCH 4/7] qapi: switch x-input-send-event from console to device+head Gerd Hoffmann
2016-01-12 12:47 ` Daniel P. Berrange
2016-01-15 16:25 ` Markus Armbruster
2016-01-12 12:29 ` [Qemu-devel] [PATCH 5/7] qapi: rename input buttons Gerd Hoffmann
2016-01-12 12:49 ` Daniel P. Berrange [this message]
2016-01-15 16:50 ` Markus Armbruster
2016-01-12 12:29 ` [Qemu-devel] [PATCH 6/7] qapi: rename input axises Gerd Hoffmann
2016-01-12 12:50 ` Daniel P. Berrange
2016-01-15 16:51 ` Markus Armbruster
2016-01-12 12:29 ` [Qemu-devel] [PATCH 7/7] qapi: promote input-send-event to stable Gerd Hoffmann
2016-01-12 12:53 ` Daniel P. Berrange
2016-01-12 13:04 ` Gerd Hoffmann
2016-01-15 16:58 ` Markus Armbruster
2016-01-12 12:42 ` [Qemu-devel] [PATCH 1/7] console: add qemu_console_lookup_by_device_name Daniel P. Berrange
2016-01-15 16:22 ` Markus Armbruster
2016-01-15 16:41 ` Markus Armbruster
2016-01-15 16:45 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160112124922.GH17626@redhat.com \
--to=berrange@redhat.com \
--cc=andreas.faerber@web.de \
--cc=armbru@redhat.com \
--cc=kraxel@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.