From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: skl_update_scaler() wants a rotation bitmask instead of bit number
Date: Tue, 19 Jan 2016 15:18:25 +0200 [thread overview]
Message-ID: <20160119131825.GR23290@intel.com> (raw)
In-Reply-To: <20160119080313.GO19130@phenom.ffwll.local>
On Tue, Jan 19, 2016 at 09:03:13AM +0100, Daniel Vetter wrote:
> On Mon, Jan 18, 2016 at 04:21:40PM +0200, Ville Syrjälä wrote:
> > On Fri, Jan 15, 2016 at 03:15:00PM -0800, Matt Roper wrote:
> > > On Fri, Jan 15, 2016 at 08:48:26PM +0200, Ville Syrjälä wrote:
> > > > On Thu, Oct 15, 2015 at 05:01:58PM +0300, ville.syrjala@linux.intel.com wrote:
> > > > > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > > >
> > > > > Pass BIT(DRM_ROTATE_0) instead of DRM_ROTATE_0 to skl_update_scaler().
> > > > > The former is a mask, the latter just the bit number.
> > > > >
> > > > > Fortunately the only thing skl_update_scaler() does with the rotation
> > > > > is check if it's 90/270 degrees or not, and so in this case it would
> > > > > still do the right thing.
> > > > >
> > > > > Cc: Chandra Konduru <chandra.konduru@intel.com>
> > > > > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > >
> > > > Ping, anyone care to r-b this one?
> > >
> > > Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
> > >
> > > Looks like this bug has been present since scalers were first added in
> > > 6156a45602f9 ("drm/i915: skylake primary plane scaling using shared scalers")
> >
> > Pushed to dinq an appropriate Fixes: comment added. Thanks for the review.
>
> Do we have an igt for this? If not need to capture it and make it
> something we must fixe before more scaler stuff lands.
There's no change in behavior from this fix, so there's nothing to test.
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-01-19 13:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-15 14:01 [PATCH] drm/i915: skl_update_scaler() wants a rotation bitmask instead of bit number ville.syrjala
2016-01-15 18:48 ` Ville Syrjälä
2016-01-15 23:15 ` Matt Roper
2016-01-18 14:21 ` Ville Syrjälä
2016-01-19 8:03 ` Daniel Vetter
2016-01-19 13:18 ` Ville Syrjälä [this message]
2016-01-19 14:01 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160119131825.GR23290@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.