From: Peter Zijlstra <peterz@infradead.org>
To: Waiman Long <waiman.long@hpe.com>
Cc: Christoph Lameter <cl@linux.com>,
Dave Chinner <david@fromorbit.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Jan Kara <jack@suse.com>, Jeff Layton <jlayton@poochiereds.net>,
"J. Bruce Fields" <bfields@fieldses.org>,
Tejun Heo <tj@kernel.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Ingo Molnar <mingo@redhat.com>, Andi Kleen <andi@firstfloor.org>,
Dave Chinner <dchinner@redhat.com>,
Scott J Norton <scott.norton@hp.com>,
Douglas Hatch <doug.hatch@hp.com>
Subject: Re: [RFC PATCH 1/2] lib/percpu-list: Per-cpu list with associated per-cpu locks
Date: Wed, 17 Feb 2016 20:39:01 +0100 [thread overview]
Message-ID: <20160217193901.GM6357@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <56C4BFCF.30100@hpe.com>
On Wed, Feb 17, 2016 at 01:45:35PM -0500, Waiman Long wrote:
> The original code has one global lock and one single list that covers all
> the inodes in the filesystem. This patch essentially breaks it up into
> multiple smaller lists with one lock for each. So the lock hold time should
> have been greatly reduced unless we are unfortunately enough that most of
> the inodes are in one single list.
Most of the inode code has lock breaks in, but in general you cannot do
that.
The more I look at that inode code, the more I think you want an inode
specific visitor interface and not bother provide something generic.
iterate_bdevs(), drop_pagecache_sb(), wait_sb_inodes(), add_dquot_ref()
all have the same pattern. And maybe fsnotify_unmount_inodes() can be
man-handled into the same form.
Afaict only invalidate_inodes() really doesn't do a lock-break, but its
very similar in form to evict_inodes() which does.
> If lock hold time is a concern, I think in some cases we can set the an
> upper limit on how many inodes we want to process, release the lock,
> reacquire it and continue. I am just worry that using RCU and 16b cmpxchg
> will introduce too much complexity with no performance gain to show.
You don't actually need cmpxchg16b in order to use RCU. But given the
users of this, you don't actually need RCU either.
Just don't try and provide a for_each_list_entry() like construct.
next prev parent reply other threads:[~2016-02-17 19:39 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-17 1:31 [RFC PATCH 0/2] vfs: Use per-cpu list for SB's s_inodes list Waiman Long
2016-02-17 1:31 ` [RFC PATCH 1/2] lib/percpu-list: Per-cpu list with associated per-cpu locks Waiman Long
2016-02-17 9:53 ` Dave Chinner
2016-02-17 11:00 ` Peter Zijlstra
2016-02-17 11:05 ` Peter Zijlstra
2016-02-17 16:16 ` Waiman Long
2016-02-17 16:22 ` Peter Zijlstra
2016-02-17 16:27 ` Christoph Lameter
2016-02-17 17:12 ` Waiman Long
2016-02-17 17:18 ` Peter Zijlstra
2016-02-17 17:41 ` Waiman Long
2016-02-17 18:22 ` Peter Zijlstra
2016-02-17 18:45 ` Waiman Long
2016-02-17 19:39 ` Peter Zijlstra [this message]
2016-02-17 11:10 ` Dave Chinner
2016-02-17 11:26 ` Peter Zijlstra
2016-02-17 11:36 ` Peter Zijlstra
2016-02-17 15:56 ` Waiman Long
2016-02-17 16:02 ` Peter Zijlstra
2016-02-17 15:13 ` Christoph Lameter
2016-02-17 1:31 ` [RRC PATCH 2/2] vfs: Use per-cpu list for superblock's inode list Waiman Long
2016-02-17 7:16 ` Ingo Molnar
2016-02-17 15:40 ` Waiman Long
2016-02-17 10:37 ` Dave Chinner
2016-02-17 16:08 ` Waiman Long
2016-02-18 23:58 ` [RFC PATCH 0/2] vfs: Use per-cpu list for SB's s_inodes list Dave Chinner
2016-02-19 21:04 ` Long, Wai Man
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160217193901.GM6357@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=andi@firstfloor.org \
--cc=bfields@fieldses.org \
--cc=cl@linux.com \
--cc=david@fromorbit.com \
--cc=dchinner@redhat.com \
--cc=doug.hatch@hp.com \
--cc=jack@suse.com \
--cc=jlayton@poochiereds.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=scott.norton@hp.com \
--cc=tj@kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=waiman.long@hpe.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.