From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Michael Trimarchi
<michael-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
Cc: lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org,
Jacob Siverskog
<jacob-EZCvousvhKUZux3j3Bed6dkegs52MxvZ@public.gmane.org>,
Johan Hovold <johan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH V3] ASoC: pcm179x: Add support for pcm1795 and pcm1796
Date: Mon, 22 Feb 2016 12:19:44 +0900 [thread overview]
Message-ID: <20160222031944.GT18327@sirena.org.uk> (raw)
In-Reply-To: <20160205172451.GA30542@panicking>
[-- Attachment #1: Type: text/plain, Size: 506 bytes --]
On Fri, Feb 05, 2016 at 06:24:57PM +0100, Michael Trimarchi wrote:
> +#define PCM1795 1
> + unsigned int codec_model;
It looks like you're trying to define an enum here.
> +static const unsigned int codec_model = PCM1795;
That's a weird name to use here. Call it pcm1795 or something, though
normally we just cast the integer to and from a pointer.
> + { .compatible = "ti,pcm1795",
> + .data = &codec_model,
> + },
This is strange indentation, just keep it on one line and it's easier to
follow.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-02-22 3:19 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-09 23:38 [RFC PATCH 0/3] ASoC: pcm1792a: Add support for pcm1795 and pcm1796 Michael Trimarchi
[not found] ` <1452382685-18009-1-git-send-email-michael-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
2016-01-09 23:38 ` [RFC PATCH 1/3] ASoC: pcm1792a: Rename internal data and function to pcm179x Michael Trimarchi
2016-01-10 12:07 ` Applied "ASoC: pcm1792a: Rename internal data and function to pcm179x" to the asoc tree Mark Brown
2016-01-09 23:38 ` [RFC PATCH 2/3] ASoC: pcm1792a: Rename pcm1792a to pcm179x Michael Trimarchi
[not found] ` <1452382685-18009-3-git-send-email-michael-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
2016-01-11 3:06 ` Rob Herring
2016-01-09 23:38 ` [RFC PATCH 3/3] ASoC: pcm179x: Add support for pcm1795 and pcm1796 Michael Trimarchi
[not found] ` <1452382685-18009-4-git-send-email-michael-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
2016-01-10 12:00 ` Mark Brown
[not found] ` <20160110120045.GW6588-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-01-10 17:38 ` [PATCH V2] " Michael Trimarchi
2016-02-05 17:24 ` [PATCH V3] " Michael Trimarchi
2016-02-20 9:27 ` Michael Trimarchi
[not found] ` <CAOf5uwnpY8J=NC82rtZ_q50mWmHqEf2gteJxZe+cXVs_3FNmrw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-02-22 8:17 ` Jacob Siverskog
2016-02-22 3:19 ` Mark Brown [this message]
[not found] ` <20160222031944.GT18327-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-03-10 9:59 ` Michael Trimarchi
2016-03-11 22:59 ` [PATCH V4] " Michael Trimarchi
2016-03-11 23:09 ` [PATCH V5] " Michael Trimarchi
2016-03-11 23:29 ` [PATCH V6] " Michael Trimarchi
2016-03-12 5:53 ` Mark Brown
[not found] ` <20160312055317.GT3898-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-03-13 8:53 ` Michael Trimarchi
2016-03-13 9:10 ` Michael Trimarchi
2016-03-14 16:24 ` Mark Brown
2016-03-18 20:08 ` Rob Herring
2016-03-12 2:50 ` [PATCH V4] " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160222031944.GT18327@sirena.org.uk \
--to=broonie-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=jacob-EZCvousvhKUZux3j3Bed6dkegs52MxvZ@public.gmane.org \
--cc=johan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=michael-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.