Re: [PATCH v3 08/11] tpm: IntroduceTPM_CHIP_FLAG_VIRTUAL

From: "Stefan Berger" <stefanb-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
To: Jason Gunthorpe
	<jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
Cc: tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [PATCH v3 08/11] tpm: IntroduceTPM_CHIP_FLAG_VIRTUAL
Date: Mon, 22 Feb 2016 22:40:32 -0500	[thread overview]
Message-ID: <201602230340.u1N3ewwD029310@d03av04.boulder.ibm.com> (raw)
In-Reply-To: <20160223020515.GA26177-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>

[-- Attachment #1.1: Type: text/plain, Size: 1442 bytes --]

Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> wrote on 02/22/2016 
09:05:15 PM:

> 
> On Mon, Feb 22, 2016 at 08:21:09PM -0500, Stefan Berger wrote:
> > 
> > Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> wrote on 02/22/
> 2016 02:19:22
> > PM:
> > 
> > 
> > > > +
> > > > +   if (!(chip->flags & TPM_CHIP_FLAG_VIRTUAL))
> > > > +      err = sysfs_create_group(&chip->dev.parent->kobj,
> > > > +                &tpm_dev_group);
> > > > +   else
> > > > +      chip->groups[chip->groups_cnt++] = &tpm_dev_group;
> > >
> > > For other reviewers: The intent here is to make another patch that
> > > moves the main sysfs to only use groups with symlinks link ppi does
> > > now.
> > >
> > > Does sysfs work with vtpm? I am worried about dev_get_drvdata here
> > > (and other places):
> > 
> > Yes, works. I have a set_drv_data in the vtpm driver.
> 
> ?? I don't see that in the vtpm patch posted to the list? Can you
> point me to it?

That was in the past that I had that call ... when there still was a 
device and when sysfs was still working.

I now converted the dev_get_drvdata in tpm-interface.c and tpm-sysfs.c to 
container_of to make sysfs work for vtpm. It has to be part of this patch.

  Stefan

> 
> In any event, the core code should be self contained and not rely on
> things in the drivers like this.
> 
> Jason
> 

[-- Attachment #1.2: Type: text/html, Size: 2045 bytes --]

[-- Attachment #2: Type: text/plain, Size: 413 bytes --]

------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140

[-- Attachment #3: Type: text/plain, Size: 192 bytes --]

_______________________________________________
tpmdd-devel mailing list
tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/tpmdd-devel