From: Wei Liu <wei.liu2@citrix.com>
To: Olaf Hering <olaf@aepfle.de>
Cc: Juergen Gross <JGross@suse.com>,
wei.liu2@citrix.com, ian.campbell@citrix.com,
george.dunlap@eu.citrix.com, Ian.Jackson@eu.citrix.com,
Chun Yan Liu <cyliu@suse.com>,
xen-devel@lists.xen.org, Jim Fehlig <JFEHLIG@suse.com>,
Simon Cao <caobosimon@gmail.com>
Subject: Re: [PATCH V13 5/5] xl: add pvusb commands
Date: Wed, 24 Feb 2016 12:03:03 +0000 [thread overview]
Message-ID: <20160224120302.GN3723@citrix.com> (raw)
In-Reply-To: <20160219120708.GA18695@gmail.com>
On Fri, Feb 19, 2016 at 01:07:08PM +0100, Olaf Hering wrote:
> On Fri, Feb 19, Olaf Hering wrote:
>
> > Not sure how to handle it, perhaps exit when xl -N is called?
>
> Also the interface is 'xl -N' is not clearly defined. What is it
> supposed to do with the newly introduced ctrl types? Should it display
> the json just for the dev, just for the ctrl+dev or the entire ctrl with
> all existing devs + the new dev?
> Who is the consumer of the json output?
> xl(1) says just "-N Dry run: do not actually execute the command."
>
> I'm asking this mainly in the context of main_vscsiattach, which right
> now dumps the enitre ctrl with all existing devs + the new dev.
>
I just turn everything into JSON and print it out?
Say, if you only add a controller, you just print the ctrl JSON. If you
add a controller and a bunch of devices, you print all of them. Does
this sound plausible?
I tend to think dryrun output is only used by administrator to eye-ball
the resulting structure. I'm not sure if it is meant to be stable at
all.
Maybe Ian has a second opinion on this.
Wei.
> Olaf
next prev parent reply other threads:[~2016-02-24 12:03 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-19 8:39 [PATCH V13 0/5] xen pvusb toolstack work Chunyan Liu
2016-01-19 8:39 ` [PATCH V13 1/5] libxl: export some functions for pvusb use Chunyan Liu
2016-01-19 8:39 ` [PATCH V13 2/5] libxl_utils: add internal function to read sysfs file contents Chunyan Liu
2016-01-19 8:39 ` [PATCH V13 3/5] libxl: add pvusb API Chunyan Liu
2016-01-19 15:48 ` Ian Jackson
2016-02-02 16:26 ` George Dunlap
2016-02-02 18:11 ` Ian Jackson
2016-02-03 7:34 ` Chun Yan Liu
2016-02-03 14:38 ` George Dunlap
2016-02-04 1:44 ` Chun Yan Liu
2016-02-03 14:33 ` George Dunlap
2016-02-04 1:53 ` Chun Yan Liu
[not found] ` <56B31FAB02000066000A6596@suse.com>
2016-02-04 14:39 ` Juergen Gross
2016-02-08 14:07 ` George Dunlap
2016-02-08 14:32 ` Ian Jackson
2016-02-02 16:48 ` George Dunlap
2016-02-03 8:25 ` Chun Yan Liu
2016-01-26 16:12 ` Olaf Hering
2016-01-27 2:29 ` Chun Yan Liu
2016-01-19 8:39 ` [PATCH V13 4/5] domcreate: support pvusb in configuration file Chunyan Liu
2016-01-19 18:08 ` Ian Jackson
2016-01-19 8:39 ` [PATCH V13 5/5] xl: add pvusb commands Chunyan Liu
2016-01-19 18:11 ` Ian Jackson
2016-01-20 3:10 ` Jim Fehlig
2016-01-21 12:12 ` Wei Liu
2016-01-21 12:21 ` Ian Campbell
2016-01-21 12:29 ` Wei Liu
2016-01-21 17:37 ` Ian Jackson
2016-02-16 17:53 ` Ian Jackson
2016-02-17 11:43 ` Wei Liu
2016-02-17 12:17 ` Ian Jackson
2016-02-16 16:56 ` Olaf Hering
2016-02-17 6:14 ` Chun Yan Liu
2016-02-19 10:43 ` Chun Yan Liu
2016-02-19 10:52 ` Olaf Hering
2016-02-19 12:07 ` Olaf Hering
2016-02-24 12:03 ` Wei Liu [this message]
2016-02-24 12:52 ` Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160224120302.GN3723@citrix.com \
--to=wei.liu2@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=JFEHLIG@suse.com \
--cc=JGross@suse.com \
--cc=caobosimon@gmail.com \
--cc=cyliu@suse.com \
--cc=george.dunlap@eu.citrix.com \
--cc=ian.campbell@citrix.com \
--cc=olaf@aepfle.de \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.