From: Chris Wilson <chris@chris-wilson.co.uk>
To: "Auld, Matthew" <matthew.auld@intel.com>
Cc: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915: add sanity check for partial view creation
Date: Thu, 3 Mar 2016 11:45:37 +0000 [thread overview]
Message-ID: <20160303114537.GR30782@nuc-i3427.alporthouse.com> (raw)
In-Reply-To: <85D4726C536E7146A9C15DB4A2CA69E5129CD89E@IRSMSX102.ger.corp.intel.com>
On Thu, Mar 03, 2016 at 11:27:47AM +0000, Auld, Matthew wrote:
> > Handle overflow?
>
> Okay, good idea.
>
> > Why do it here and not at creation?
>
> We could, given that we currently only exercise partial views in the gem fault handler code, but as Joonas mentioned we are expecting further use of partial views, so it makes sense to have the check in only one place.
More use of broken code? Please review the patches to fix the current
implementation first!
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-03-03 11:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-02 14:33 [PATCH] drm/i915: add sanity check for partial view creation Matthew Auld
2016-03-02 14:42 ` Chris Wilson
2016-03-03 11:27 ` Auld, Matthew
2016-03-03 11:45 ` Chris Wilson [this message]
2016-03-02 15:02 ` ✗ Fi.CI.BAT: failure for drm/i915: add sanity check for partial view creation (rev2) Patchwork
-- strict thread matches above, loose matches on Subject: below --
2016-03-18 15:51 [PATCH] drm/i915: add sanity check for partial view creation Matthew Auld
2016-03-04 10:11 Matthew Auld
2016-03-04 10:53 ` Chris Wilson
2016-03-09 18:31 ` Matthew Auld
2016-02-29 17:11 Matthew Auld
2016-02-29 17:57 ` Ville Syrjälä
2016-03-02 13:37 ` Joonas Lahtinen
2016-03-02 13:29 ` Joonas Lahtinen
2016-03-02 13:35 ` Chris Wilson
2016-03-02 13:33 ` Tvrtko Ursulin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160303114537.GR30782@nuc-i3427.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.auld@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.