From: Fam Zheng <famz@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: kwolf@redhat.com, peter.maydell@linaro.org, sw@weilnetz.de,
qemu-devel@nongnu.org, stefanha@redhat.com,
Paolo Bonzini <pbonzini@redhat.com>,
jsnow@redhat.com, david@gibson.dropbear.id.au
Subject: Re: [Qemu-devel] [PATCH v3 02/13] Makefile: Rules for docker testing
Date: Wed, 16 Mar 2016 11:37:11 +0800 [thread overview]
Message-ID: <20160316033711.GB32324@ad.usersys.redhat.com> (raw)
In-Reply-To: <87vb4tt5h6.fsf@linaro.org>
On Fri, 03/11 15:11, Alex Bennée wrote:
>
> Fam Zheng <famz@redhat.com> writes:
>
> > This adds a group of make targets to run docker tests, all are available
> > in source tree without running ./configure.
> >
> > The usage is shown by "make docker".
> >
> > Besides the fixed ones, dynamic targets for building each image and
> > running each test in each image are generated automatically by make,
> > scanning $(SRC_PATH)/tests/docker/ files with specific patterns.
> >
> > Alternative to manually list particular targets (docker-run-FOO@BAR)
> > set, you can control which tests/images to run by filtering variables,
> > TESTS= and IMAGES=, which are expressed in Makefile pattern syntax,
> > "foo% %bar ...". For example:
> >
> > $ make docker-run IMAGES="ubuntu fedora"
>
> I thought I mentioned this last time, it needs fixing in the commit
> message:
>
> 15:05 alex@zen/x86_64 [qemu.git/review/docker-v3] >make docker-run
> IMAGES="ubuntu fedora"
> make: *** No rule to make target `docker-run'. Stop.
My bad!
>
> >
> > Unfortunately, it's impossible to propagate "-j $JOBS" into make in
> > containers, however since each combination is made a first class target
> > is the top Makefile, "make -j$N docker-run" still parallels the tests
> > coarsely.
> >
> > Instead of providing a live version of the source tree to the docker
> > container we snapshot it with git-archive. This ensure the tree is in a
> > pristine state for whatever operations the container is going to run on
> > them.
> >
> > Uncommitted changes known to files known by the git index will be
> > included in the snapshot if there are any.
> >
> > Signed-off-by: Fam Zheng <famz@redhat.com>
> > Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>
> fix the commit message and have a:
>
> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Thanks!
Fam
next prev parent reply other threads:[~2016-03-16 3:37 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-04 10:18 [Qemu-devel] [PATCH v3 00/13] tests: Introducing docker tests Fam Zheng
2016-03-04 10:18 ` [Qemu-devel] [PATCH v3 01/13] tests: Add utilities for docker testing Fam Zheng
2016-03-11 15:04 ` Alex Bennée
2016-03-16 3:24 ` Fam Zheng
2016-03-04 10:18 ` [Qemu-devel] [PATCH v3 02/13] Makefile: Rules " Fam Zheng
2016-03-11 15:11 ` Alex Bennée
2016-03-16 3:37 ` Fam Zheng [this message]
2016-03-04 10:18 ` [Qemu-devel] [PATCH v3 03/13] docker: Add images Fam Zheng
2016-03-11 15:11 ` Alex Bennée
2016-03-04 10:18 ` [Qemu-devel] [PATCH v3 04/13] docker: Add test runner Fam Zheng
2016-03-11 16:05 ` Alex Bennée
2016-03-04 10:18 ` [Qemu-devel] [PATCH v3 05/13] docker: Add common.rc Fam Zheng
2016-03-11 16:06 ` Alex Bennée
2016-03-16 3:39 ` Fam Zheng
2016-03-04 10:18 ` [Qemu-devel] [PATCH v3 06/13] docker: Add quick test Fam Zheng
2016-03-11 16:09 ` Alex Bennée
2016-03-04 10:18 ` [Qemu-devel] [PATCH v3 07/13] docker: Add full test Fam Zheng
2016-03-11 16:10 ` Alex Bennée
2016-03-16 3:42 ` Fam Zheng
2016-03-16 9:07 ` Alex Bennée
2016-03-04 10:18 ` [Qemu-devel] [PATCH v3 08/13] docker: Add clang test Fam Zheng
2016-03-11 16:11 ` Alex Bennée
2016-03-04 10:18 ` [Qemu-devel] [PATCH v3 09/13] docker: Add mingw test Fam Zheng
2016-03-11 16:12 ` Alex Bennée
2016-03-04 10:18 ` [Qemu-devel] [PATCH v3 10/13] docker: Add travis tool Fam Zheng
2016-03-11 16:14 ` Alex Bennée
2016-03-16 3:49 ` Fam Zheng
2016-03-16 9:09 ` Alex Bennée
2016-03-16 9:29 ` Fam Zheng
2016-03-16 10:21 ` Alex Bennée
2016-03-04 10:18 ` [Qemu-devel] [PATCH v3 11/13] docs: Add text for tests/docker in build-system.txt Fam Zheng
2016-03-11 16:14 ` Alex Bennée
2016-03-04 10:18 ` [Qemu-devel] [PATCH v3 12/13] .gitignore: Ignore temporary dockerfile Fam Zheng
2016-03-11 16:14 ` Alex Bennée
2016-03-16 6:31 ` Fam Zheng
2016-03-04 10:18 ` [Qemu-devel] [PATCH v3 13/13] MAINTAINERS: Add tests/docker Fam Zheng
2016-03-11 16:16 ` [Qemu-devel] [PATCH v3 00/13] tests: Introducing docker tests Alex Bennée
2016-03-16 3:54 ` Fam Zheng
2016-03-16 9:10 ` Alex Bennée
2016-03-17 10:13 ` Daniel P. Berrange
2016-03-17 10:38 ` Alex Bennée
2016-03-17 11:35 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160316033711.GB32324@ad.usersys.redhat.com \
--to=famz@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=david@gibson.dropbear.id.au \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.