From: David Sterba <dsterba@suse.cz>
To: Anand Jain <anand.jain@oracle.com>
Cc: linux-btrfs@vger.kernel.org, dsterba@suse.cz, clm@fb.com
Subject: Re: [PATCH] btrfs: rename btrfs_std_error() to btrfs_handle_fs_error()
Date: Wed, 16 Mar 2016 11:14:12 +0100 [thread overview]
Message-ID: <20160316101411.GI21722@twin.jikos.cz> (raw)
In-Reply-To: <1458117788-840-2-git-send-email-anand.jain@oracle.com>
On Wed, Mar 16, 2016 at 04:43:06PM +0800, Anand Jain wrote:
> btrfs_std_error() handles errors, puts FS into readonly mode
> (as of now). So its good idea to rename it to btrfs_handle_fs_error().
> So that bugs like
> btrfs: pass the error code to the btrfs_std_error and log ret
> (in the ML) may be avoided.
>
> Signed-off-by: Anand Jain <anand.jain@oracle.com>
Reviewed-by: David Sterba <dsterba@suse.com>
btrfs_handle_fs_error is much better.
next prev parent reply other threads:[~2016-03-16 10:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-16 8:43 [PATCH] btrfs: rename save_error_info to set_fs_error Anand Jain
2016-03-16 8:43 ` [PATCH] btrfs: rename btrfs_std_error() to btrfs_handle_fs_error() Anand Jain
2016-03-16 10:14 ` David Sterba [this message]
2016-03-16 8:43 ` [PATCH] btrfs: remove unused function btrfs_assert() Anand Jain
2016-03-16 10:15 ` David Sterba
2016-03-16 8:43 ` [PATCH 5/5] btrfs: move error handling code together in ctree.h Anand Jain
2016-03-16 10:17 ` David Sterba
2016-03-16 10:05 ` [PATCH] btrfs: rename save_error_info to set_fs_error David Sterba
2016-03-16 13:42 ` Anand Jain
2016-03-16 15:49 ` David Sterba
2016-03-17 2:30 ` Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160316101411.GI21722@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=anand.jain@oracle.com \
--cc=clm@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.