From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Stefan Berger <stefanb@linux.vnet.ibm.com>
Cc: tpmdd-devel@lists.sourceforge.net,
jgunthorpe@obsidianresearch.com,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
linux-api@vger.kernel.org
Subject: Re: [PATCH v8 08/10] tpm: Proxy driver for supporting multiple emulated TPMs
Date: Fri, 18 Mar 2016 15:06:47 +0200 [thread overview]
Message-ID: <20160318130647.GA14067@intel.com> (raw)
In-Reply-To: <20160318085200.GA5604@intel.com>
On Fri, Mar 18, 2016 at 10:52:00AM +0200, Jarkko Sakkinen wrote:
> On Thu, Mar 17, 2016 at 01:45:20PM -0400, Stefan Berger wrote:
> > On 03/16/2016 04:42 PM, Jarkko Sakkinen wrote:
> > >On Sun, Mar 13, 2016 at 06:54:38PM -0400, Stefan Berger wrote:
> > >>+
> > >>+/* above flags */
> > >>+#define VTPM_PROXY_FLAG_TPM2 1 /* emulator is TPM 2 */
> > >>+
> > >>+/* all supported flags */
> > >>+#define VTPM_PROXY_FLAGS_ALL (VTPM_PROXY_FLAG_TPM2)
> > >This can be moved inside the .c-file?
> >
> > I can move that.
> >
> > >
> > >>+
> > >>+#define VTPM_PROXY_MAGIC 0xa1
> > >>+
> > >>+#define VTPM_PROXY_IOC_NEW_DEV _IOW(VTPM_PROXY_MAGIC, 0x00, \
> > >>+ struct vtpm_proxy_new_dev)
> > >Could we simply replace these four lines with one line:
> > >
> > >#deifne VTPM_PROXY_IOC_NEW_DEV _IOW('t', 0x00, struct vtpm_proxy_new_dev);
> >
> > Does this make it better?
> >
> > >
> > >I changed the magic but does it matter?
> >
> > I would keep the magic at '0xa1'. The documentation is written to '0xa1' now
> > and seems to be good just as any other.
>
> OK. Works for me. Keep the ioctl definition as it is.
>
> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
>
> I can move the constant. You don't have to send a new patch version
> anymore. I start keeping this patch in my master but will not merge it
> to next before 4.6-rc5 so at the moment it would be scheduled for 4.7.
> Does this sound good for you?
>
> Further improvemnts should be sent as separate fixup patches.
Applied to git://git.infradead.org/users/jjs/linux-tpmdd.git.
/Jarkko
next prev parent reply other threads:[~2016-03-18 13:08 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-13 22:54 [PATCH v8 00/10] Multi-instance vTPM proxy driver Stefan Berger
2016-03-13 22:54 ` Stefan Berger
2016-03-13 22:54 ` [PATCH v8 01/10] tpm: Get rid of chip->pdev Stefan Berger
2016-03-13 22:54 ` Stefan Berger
2016-03-13 22:54 ` [PATCH v8 02/10] tpm: Get rid of devname Stefan Berger
2016-03-13 22:54 ` Stefan Berger
2016-03-13 22:54 ` [PATCH v8 03/10] tpm: Provide strong locking for device removal Stefan Berger
2016-03-13 22:54 ` Stefan Berger
2016-03-13 22:54 ` [PATCH v8 04/10] tpm: Get rid of module locking Stefan Berger
2016-03-13 22:54 ` Stefan Berger
2016-03-13 22:54 ` [PATCH v8 05/10] tpm: Split out the devm stuff from tpmm_chip_alloc Stefan Berger
2016-03-13 22:54 ` Stefan Berger
2016-03-13 22:54 ` [PATCH v8 06/10] tpm: Replace device number bitmap with IDR Stefan Berger
2016-03-13 22:54 ` Stefan Berger
2016-03-15 5:58 ` Jarkko Sakkinen
2016-03-13 22:54 ` [PATCH v8 07/10] tpm: Introduce TPM_CHIP_FLAG_VIRTUAL Stefan Berger
2016-03-13 22:54 ` Stefan Berger
2016-03-13 22:54 ` [PATCH v8 08/10] tpm: Proxy driver for supporting multiple emulated TPMs Stefan Berger
2016-03-13 22:54 ` Stefan Berger
2016-03-14 16:26 ` Jarkko Sakkinen
2016-03-16 12:09 ` Jarkko Sakkinen
2016-03-16 12:09 ` Jarkko Sakkinen
2016-03-16 13:49 ` Stefan Berger
2016-03-16 13:49 ` Stefan Berger
2016-03-16 17:49 ` Jason Gunthorpe
2016-03-16 20:37 ` Jarkko Sakkinen
2016-03-16 20:37 ` Jarkko Sakkinen
2016-03-16 20:42 ` Jarkko Sakkinen
2016-03-17 17:45 ` Stefan Berger
2016-03-17 17:45 ` Stefan Berger
2016-03-18 8:52 ` Jarkko Sakkinen
[not found] ` <20160318085200.GA5604-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-03-18 11:58 ` Stefan Berger
2016-03-18 13:06 ` Jarkko Sakkinen [this message]
2016-03-13 22:54 ` [PATCH v8 09/10] tpm: Initialize TPM and get durations and timeouts Stefan Berger
2016-03-13 22:54 ` Stefan Berger
2016-03-22 6:34 ` [v8,09/10] " Jarkko Sakkinen
2016-03-22 10:54 ` Stefan Berger
2016-03-29 15:31 ` [v8,09/10] tpm: Initialize TPM and get durations and timeoutsg Jarkko Sakkinen
2016-03-29 15:53 ` Stefan Berger
2016-03-29 15:53 ` Stefan Berger
2016-03-13 22:54 ` [PATCH v8 10/10] tpm: Add documentation for the tpm_vtpm device driver Stefan Berger
2016-03-13 22:54 ` Stefan Berger
2016-03-29 16:24 ` [PATCH v8 00/10] Multi-instance vTPM proxy driver Jarkko Sakkinen
[not found] ` <20160329162433.GB24833-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-03-29 16:31 ` Stefan Berger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160318130647.GA14067@intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=stefanb@linux.vnet.ibm.com \
--cc=tpmdd-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.