All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: Anand Jain <anand.jain@oracle.com>
Cc: dsterba@suse.cz, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2] btrfs-progs: subvolume functions reorg
Date: Fri, 18 Mar 2016 14:31:36 +0100	[thread overview]
Message-ID: <20160318133136.GY21722@twin.jikos.cz> (raw)
In-Reply-To: <56EBC240.40306@oracle.com>

On Fri, Mar 18, 2016 at 04:54:24PM +0800, Anand Jain wrote:
> 
> 
> On 03/17/2016 10:19 PM, David Sterba wrote:
> > On Wed, Mar 16, 2016 at 10:14:33PM +0800, Anand Jain wrote:
> >> Makes few subvol related functions usable outside of subvol
> >> command set.
> >>
> >> This is a preparatory patch for encryption support. The changes
> >> here are:
> >>
> >> Created new file subvolume.c
> >> Created btrfs_get_subvol_info() from parts of cmd_subvol_show()
> >> Moved get_subvol_name() to subvolume.c
> >> Moved test_issubvolume() to subvolume.c
> >> Created subvolume.h to define the above functions.
> >
> > Such helpers are in utils.[ch], eg. there's test_issubvolname.
> 
>   You meant to move them/it to subvolume.c/h right ?

No, please keep using utils.[ch] for now.

  reply	other threads:[~2016-03-18 13:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-16 14:14 [PATCH v2] btrfs-progs: subvolume functions reorg Anand Jain
2016-03-17 14:19 ` David Sterba
2016-03-18  8:54   ` Anand Jain
2016-03-18 13:31     ` David Sterba [this message]
2016-03-21  7:24       ` Anand Jain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160318133136.GY21722@twin.jikos.cz \
    --to=dsterba@suse.cz \
    --cc=anand.jain@oracle.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.