All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kent Overstreet <kent.overstreet@gmail.com>
To: Ming Lei <ming.lei@canonical.com>
Cc: Jens Axboe <axboe@fb.com>,
	linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
	Christoph Hellwig <hch@infradead.org>,
	Eric Wheeler <bcache@lists.ewheeler.net>,
	Sebastian Roesner <sroesner-kernelorg@roesner-online.de>,
	"4.2+" <stable@vger.kernel.org>, Shaohua Li <shli@fb.com>
Subject: Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs
Date: Tue, 5 Apr 2016 16:30:25 -0800	[thread overview]
Message-ID: <20160406003025.GC31161@kmo-pixel> (raw)
In-Reply-To: <1459878246-9249-1-git-send-email-ming.lei@canonical.com>

On Wed, Apr 06, 2016 at 01:44:06AM +0800, Ming Lei wrote:
> After arbitrary bio size is supported, the incoming bio may
> be very big. We have to split the bio into small bios so that
> each holds at most BIO_MAX_PAGES bvecs for safety reason, such
> as bio_clone().
> 
> This patch fixes the following kernel crash:

Ming, let's not do it this way; drivers that don't clone biovecs are the norm -
instead, md has its own queue limits that it ought to be setting up correctly.

  parent reply	other threads:[~2016-04-06  0:30 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-05 17:44 [PATCH] block: make sure big bio is splitted into at most 256 bvecs Ming Lei
2016-04-05 18:27 ` Shaohua Li
2016-04-06  0:27   ` Kent Overstreet
2016-04-06  0:30     ` Shaohua Li
2016-04-06  0:36       ` Kent Overstreet
2016-04-06  0:41         ` Shaohua Li
2016-04-06  0:45           ` Kent Overstreet
2016-04-06  0:59             ` Shaohua Li
2016-04-06  1:05               ` Ming Lei
2016-04-06  0:47   ` Ming Lei
2016-04-06  1:04     ` Shaohua Li
2016-04-06  1:11       ` Ming Lei
2016-04-06  0:30 ` Kent Overstreet [this message]
2016-04-06  0:59   ` Ming Lei
2016-04-06  1:10     ` Kent Overstreet
2016-04-06  1:20       ` Ming Lei
2016-04-06  1:28         ` Kent Overstreet
2016-04-06  1:51           ` Ming Lei
2016-04-06  2:22             ` Kent Overstreet
2016-04-06  2:30               ` Ming Lei
2016-04-06  2:34                 ` Kent Overstreet
2016-04-06  2:37                   ` Ming Lei
2016-04-06  2:40                     ` Kent Overstreet
2016-04-06  2:51                       ` Ming Lei
2016-04-06  2:58                         ` Kent Overstreet
2016-04-06  1:02 ` Ming Lei
2016-04-07  1:48   ` Eric Wheeler
2016-04-07  1:36 ` Eric Wheeler
2016-04-07  1:49   ` Ming Lei
2016-04-07  1:56     ` Eric Wheeler
2016-04-07  2:16       ` Ming Lei
2016-04-07 23:29         ` Eric Wheeler
2016-04-08  0:21           ` Ming Lei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160406003025.GC31161@kmo-pixel \
    --to=kent.overstreet@gmail.com \
    --cc=axboe@fb.com \
    --cc=bcache@lists.ewheeler.net \
    --cc=hch@infradead.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ming.lei@canonical.com \
    --cc=shli@fb.com \
    --cc=sroesner-kernelorg@roesner-online.de \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.