All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: "Denis V. Lunev" <den@openvz.org>
Cc: Max Reitz <mreitz@redhat.com>, John Snow <jsnow@redhat.com>,
	qemu-devel@nongnu.org, Pavel Butsykin <pbutsykin@virtuozzo.com>
Subject: Re: [Qemu-devel] [PATCH for 2.6 1/1] iotests: fix the broken 026.nocache output
Date: Wed, 6 Apr 2016 12:09:57 +0200	[thread overview]
Message-ID: <20160406100957.GC5098@noname.redhat.com> (raw)
In-Reply-To: <1459922912-31715-1-git-send-email-den@openvz.org>

Am 06.04.2016 um 08:08 hat Denis V. Lunev geschrieben:
> From: Pavel Butsykin <pbutsykin@virtuozzo.com>
> 
> This patch fixes longstanding issue with 026 iotest. Unfortunately,
> this test contains 2 versions of the correct output, one for cached
> writes and one for non-cached ones. People tends to fix only one
> version of output of the test and thus noncached version becomes
> broken. Unfortunately, it is default in tests/check-block.sh
> 
> The following problematic commits were made:
>     commit 3b5e14c76a6bb142bf250ddf99e24a0ac8c7bc12
>     Author: Max Reitz <mreitz@redhat.com>
>     Date:   Tue Dec 2 18:32:51 2014 +0100
>     qcow2: Flushing the caches in qcow2_close may fail
> 
>     commit a069e2f1372a0a823ab506fc019852a2a652aa54
>     Author: John Snow <jsnow@redhat.com>
>     Date:   Fri Feb 6 16:26:17 2015 -0500
>     blkdebug: fix "once" rule
> 
>     commit b106ad9185f35fc4ad669555ad0e79e276083bd7
>     Author: Kevin Wolf <kwolf@redhat.com>
>     Date:   Fri Mar 28 18:06:31 2014 +0100
>     qcow2: Don't rely on free_cluster_index in alloc_refcount_block()
> 
> Signed-off-by: Pavel Butsykin <pbutsykin@virtuozzo.com>
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> CC: Max Reitz <mreitz@redhat.com>
> CC: John Snow <jsnow@redhat.com>
> CC: Kevin Wolf <kwolf@redhat.com>

Thanks for tracking this down! It's always amazing to have a patch where
the commit message is by far more work than the actual patch, and this
is certainly one of them. With these references to older commits, the
changes look all good.

Applied to the block branch.

Kevin

      reply	other threads:[~2016-04-06 10:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-06  6:08 [Qemu-devel] [PATCH for 2.6 1/1] iotests: fix the broken 026.nocache output Denis V. Lunev
2016-04-06 10:09 ` Kevin Wolf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160406100957.GC5098@noname.redhat.com \
    --to=kwolf@redhat.com \
    --cc=den@openvz.org \
    --cc=jsnow@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=pbutsykin@virtuozzo.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.