All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: "Zanoni, Paulo R" <paulo.r.zanoni@intel.com>
Cc: "intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>,
	"Konno, Joe" <joe.konno@intel.com>,
	"Swaminathan, Nivedita" <nivedita.swaminathan@intel.com>,
	"Vivi, Rodrigo" <rodrigo.vivi@intel.com>
Subject: Re: [PATCH 0/5] PowerManagement Toggle for PowerTOP
Date: Wed, 13 Apr 2016 16:50:03 +0200	[thread overview]
Message-ID: <20160413145002.GD2510@phenom.ffwll.local> (raw)
In-Reply-To: <1460552356.8441.13.camel@intel.com>

On Wed, Apr 13, 2016 at 12:59:18PM +0000, Zanoni, Paulo R wrote:
> Em Ter, 2016-04-12 às 12:18 -0700, Alexandra Yates escreveu:
> > This project is explained in detail on the HAS
> > https://docs.google.com/a/intel.com/document/d/1E-en_xqfHgCnhD1Tes3f0
> > 8UYrOc-etv2W-pU0ZErKdE/edit?usp=sharing  
> > 
> > Summary: 
> > Permits the user to identify and toggle values for PSR, FBC, RC6,
> > DRRS, and IPS
> > under /sys/class/drm/card0/power/.  By enabling these features I'm
> > looking to
> > empower our customers, such as, power team, chrome OS, and platform
> > integration teams
> > to debug graphics power management features. 
> > 
> > From the current patchset PSR, FBC, RC6, and, DRRS are complete and
> > past BAT, modset,
> > and suspend/resume tests.  For IPS I'm looking for feedback since IPS
> > seems to change
> > during runtime dynamically.  Additionally, as a future project IPS
> > would be better 
> > served if it is implemented by using the atomic check, pre-commit,
> > commit, post-commit,
> > a good example of this is the PSR enable/disable implementation.
> > 
> > For this project to be completed needs to have in place the following
> > components:
> > (Need to be developed)
> > * IPS toggle interface flesh-out
> > * Tests added to intel-gpu-tools repo
> > * Documentation for all sysfs added interfaces
> > * PowerTOP component named: GFX-TOP. With the following requirements:
> > 	* It would be available only to developers
> > 	* It would allow the developers to toggle the interfaces from
> > 	  the PowerTOP user interface.  
> > 	* It would show the Power Consumption impact of toggling on and
> > off
> > 	  these settings.      
> >      
> 
> A small suggestion:
> 
> In the past, I've seen people testing i915.ko power saving features
> just by "toggling" the features through the i915 module parameters
> without doing anything else. In most of these cases, the machine was
> not properly configured for power savings, so the conclusion was often
> that the feature didn't save any power. While this was true (toggling
> the feature didn't save any power), these people would have reached
> different conclusions if they had, for example, changed their disk
> power management policies. Do we have any sort of plan to try to
> educate the powertop/gfxtop users regarding these things?
> 
> Maybe the powertop/gfxtop interface could expose some very-easy-to-
> reach text explaining these things.

I think trying to extract/reuse those from the igt testcases might be
really useful. I.e. add docs that explain
a) what igt must past of a feature to be considered working
b) add some functions to igt testcases for manually enabling/disabling a
given rpm feature. The tests already know how to do that, and most have
nice explanations about what all should be changed on top to make things
work.
-Daniel

> 
> 
> > Your review of this patchset is intended to contribute to its full
> > maturity so that when we reach the PowerTOP development all pieces
> > would
> > be ready for commit.  
> > 
> > Thank you in advance,
> > 
> > Alexandra Yates (5):
> >   drm/i915: Add sys PSR toggle interface
> >   drm/i915: Add sys FBC toggle interface
> >   drm/i915: Add sys RC6 toggle interface
> >   drm/i915: Add sys drrs toggle interface
> >   drm-i915: Add sys IPS toggle interface
> > 
> >  drivers/gpu/drm/i915/i915_debugfs.c  |   5 +-
> >  drivers/gpu/drm/i915/i915_drv.c      |   5 +-
> >  drivers/gpu/drm/i915/i915_drv.h      |  12 ++
> >  drivers/gpu/drm/i915/i915_sysfs.c    | 362
> > ++++++++++++++++++++++++++++++++++-
> >  drivers/gpu/drm/i915/intel_color.c   |  12 +-
> >  drivers/gpu/drm/i915/intel_ddi.c     |  15 +-
> >  drivers/gpu/drm/i915/intel_display.c |  55 ++++--
> >  drivers/gpu/drm/i915/intel_dp.c      |  48 +++--
> >  drivers/gpu/drm/i915/intel_drv.h     |  21 +-
> >  drivers/gpu/drm/i915/intel_fbc.c     |  29 ++-
> >  drivers/gpu/drm/i915/intel_pm.c      |  53 ++++-
> >  drivers/gpu/drm/i915/intel_psr.c     |  36 +++-
> >  12 files changed, 588 insertions(+), 65 deletions(-)
> > 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2016-04-13 14:49 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <gfx-top>
2016-04-12 19:18 ` [PATCH 0/5] PowerManagement Toggle for PowerTOP Alexandra Yates
2016-04-12 19:18   ` [PATCH 1/5] drm/i915: Add sys PSR toggle interface Alexandra Yates
2016-04-13 13:26     ` Zanoni, Paulo R
2016-04-13 20:43       ` Vivi, Rodrigo
2016-04-14  7:58         ` Jani Nikula
2016-04-12 19:18   ` [PATCH 2/5] drm/i915: Add sys FBC " Alexandra Yates
2016-04-13 12:48     ` Zanoni, Paulo R
2016-04-12 19:18   ` [PATCH 3/5] drm/i915: Add sys RC6 " Alexandra Yates
2016-04-12 19:18   ` [PATCH 4/5] drm/i915: Add sys drrs " Alexandra Yates
2016-04-12 19:18   ` [PATCH 5/5] drm-i915: Add sys IPS " Alexandra Yates
2016-04-13 10:21   ` [PATCH 0/5] PowerManagement Toggle for PowerTOP Daniel Vetter
2016-04-13 10:24   ` Jani Nikula
2016-04-13 12:59   ` Zanoni, Paulo R
2016-04-13 14:50     ` Daniel Vetter [this message]
2016-04-13 20:38       ` Vivi, Rodrigo
2016-04-13 20:46         ` Daniel Vetter
2016-04-13 20:49           ` Daniel Vetter
2016-04-13 22:06           ` Vivi, Rodrigo
2016-04-14  9:48             ` Daniel Vetter
2016-04-14 17:17               ` Alexandra Yates
2016-04-15 18:12               ` Vivi, Rodrigo
2016-04-20 12:44                 ` Daniel Vetter
2016-04-13 15:25 ` ✗ Fi.CI.BAT: failure for series starting with [1/5] drm/i915: Add sys PSR toggle interface Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160413145002.GD2510@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=joe.konno@intel.com \
    --cc=nivedita.swaminathan@intel.com \
    --cc=paulo.r.zanoni@intel.com \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.