From: Mark Brown <broonie@kernel.org>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Sangbeom Kim <sbkim73@samsung.com>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [PATCH] regulator: s2mps11: Remove unused set_voltage_time_sel
Date: Mon, 18 Apr 2016 12:00:01 +0100 [thread overview]
Message-ID: <20160418110001.GS3217@sirena.org.uk> (raw)
In-Reply-To: <5714B8C4.5070207@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 803 bytes --]
On Mon, Apr 18, 2016 at 12:36:52PM +0200, Krzysztof Kozlowski wrote:
> On 04/18/2016 11:57 AM, Mark Brown wrote:
> > That's not the bug, the bug is that the driver is providing the
> > operation without providing a non-zero value for it. The device tree
> > configuration is to override what the driver is doing.
> So your recommendation would be to set the ramp_delay value in
> regulator_desc structure?
Or at least fix the changelog to describe the problem more clearly.
> The problem is that value of 30 mv/us in datasheet looks untrustworthy
> (copied from other pages) and vendor kernel (which should be a
> reference) uses 12 mv/us. Anyway setting any value greater than 0 seems
> like better idea than just sticking to 0...
Yup. Probably the more conservative value is going to be safer.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2016-04-18 11:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-18 7:42 [PATCH] regulator: s2mps11: Remove unused set_voltage_time_sel Krzysztof Kozlowski
2016-04-18 9:57 ` Mark Brown
2016-04-18 10:36 ` Krzysztof Kozlowski
2016-04-18 11:00 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160418110001.GS3217@sirena.org.uk \
--to=broonie@kernel.org \
--cc=b.zolnierkie@samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=sbkim73@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.