From: Guenter Roeck <linux@roeck-us.net>
To: Huang Rui <ray.huang@amd.com>
Cc: Jean Delvare <jdelvare@suse.de>,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
Borislav Petkov <bp@alien8.de>,
Sherry Hurwitz <sherry.hurwitz@amd.com>
Subject: Re: [v6,1/6] hwmon: (fam15h_power) Add CPU_SUP_AMD as the dependence
Date: Tue, 19 Apr 2016 06:35:26 -0700 [thread overview]
Message-ID: <20160419133526.GA26875@roeck-us.net> (raw)
In-Reply-To: <1459928655-6071-2-git-send-email-ray.huang@amd.com>
On Wed, Apr 06, 2016 at 03:44:10PM +0800, Huang Rui wrote:
> This patch adds CONFIG_CPU_SUP_AMD as the dependence of fam15h_power
> driver. Because the following patch will use the interface from
> x86/kernel/cpu/amd.c.
>
> Otherwise, the below error might be encountered:
>
> All errors (new ones prefixed by >>):
>
> drivers/built-in.o: In function `fam15h_power_probe':
> >> fam15h_power.c:(.text+0x26e3a3): undefined reference to
> >> `amd_get_cores_per_cu'
> fam15h_power.c:(.text+0x26e41e): undefined reference to
> `amd_get_cores_per_cu'
>
> Reported-by: build test robot <lkp@intel.com>
> Acked-by: Borislav Petkov <bp@suse.de>
> Signed-off-by: Huang Rui <ray.huang@amd.com>
>
Series applied.
Thanks,
Guenter
> ---
> drivers/hwmon/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
> index 5c2d13a..4be3792 100644
> --- a/drivers/hwmon/Kconfig
> +++ b/drivers/hwmon/Kconfig
> @@ -288,7 +288,7 @@ config SENSORS_K10TEMP
>
> config SENSORS_FAM15H_POWER
> tristate "AMD Family 15h processor power"
> - depends on X86 && PCI
> + depends on X86 && PCI && CPU_SUP_AMD
> help
> If you say yes here you get support for processor power
> information of your AMD family 15h CPU.
next prev parent reply other threads:[~2016-04-19 13:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-06 7:44 [PATCH v6 0/6] hwmon: (fam15h_power) Introduce an accumulated power reporting algorithm Huang Rui
2016-04-06 7:44 ` [PATCH v6 1/6] hwmon: (fam15h_power) Add CPU_SUP_AMD as the dependence Huang Rui
2016-04-19 13:35 ` Guenter Roeck [this message]
2016-04-06 7:44 ` [PATCH v6 2/6] hwmon: (fam15h_power) Add compute unit accumulated power Huang Rui
2016-04-06 15:30 ` Guenter Roeck
2016-04-07 5:05 ` Huang Rui
2016-04-07 5:25 ` Guenter Roeck
2016-04-06 7:44 ` [PATCH v6 3/6] hwmon: (fam15h_power) Add ptsc counter value for " Huang Rui
2016-04-06 7:44 ` [PATCH v6 4/6] hwmon: (fam15h_power) Introduce a cpu accumulated power reporting algorithm Huang Rui
2016-04-06 7:44 ` [PATCH v6 5/6] hwmon: (fam15h_power) Add documentation for TDP and accumulated power algorithm Huang Rui
2016-04-06 7:44 ` [PATCH v6 6/6] hwmon: (fam15h_power) Add platform check function Huang Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160419133526.GA26875@roeck-us.net \
--to=linux@roeck-us.net \
--cc=bp@alien8.de \
--cc=jdelvare@suse.de \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ray.huang@amd.com \
--cc=sherry.hurwitz@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.