Re: [PATCH v3 0/9] ASoC: hdac_hdmi: Add multichannel support

From: "Subhransu S. Prusty" <subhransu.s.prusty@intel.com>
To: alsa-devel@alsa-project.org
Cc: tiwai@suse.de, patches.audio@intel.com, broonie@kernel.org,
	lgirdwood@gmail.com
Subject: Re: [PATCH v3 0/9] ASoC: hdac_hdmi: Add multichannel support
Date: Tue, 26 Apr 2016 10:19:18 +0530	[thread overview]
Message-ID: <20160426044917.GB10261@subhransu-desktop> (raw)
In-Reply-To: <1460608656-8860-1-git-send-email-subhransu.s.prusty@intel.com>

On Thu, Apr 14, 2016 at 10:07:27AM +0530, Subhransu S. Prusty wrote:
> This series parses ELD to identify multichannel capability of the
> sync, and uses HDA framework to programs codec's channel map
> registers.
> 
> Channel map controls are registered in patch 8, with which user
> can specify a specific channel order. chmap controls are
> registered inside jack_init callback. As PCMs need to be
> registered before registering chmap controls, jack_init call in
> the machine driver is moved to late_probe instead of init
> callback.
> 
> Skylake driver is modified and buffer size calculation is fixed
> for multichannel support.
> 
> Please note, patch 2 adds a small macro to read channel counts
> from cap bits in HDA headers. This needs Takashi's ack, so that
> it can be merged through ASoC.
> 
> Patch 7 has dependency on commit#44fde3b ("ALSA: hda - Update
> chmap tlv to report sink's capability) which is merged in
> Takashi's tree.
> 
> As Takashi suggested Mark may pull Takashi's for-next branch
> before applying this or may send a pull request, so that Takashi
> pull's Mark's tree before applying these with Mark's ack.
> 
> Mark, please check how you want this to be merged.

Hi Mark,

How are you planning to merge this, will you merge takashi tree or you
want this to be merged thru his tree? We prefer former as that would
reduce conflicts for upcoming patches.

Regards,
Subhransu
> 
> Changes in v3:
> 	* As suggested, simplified channel calculation expression
> 	  in get channel helper
> 	* Removed condition in max channel assignment expression
> 
> Subhransu S. Prusty (9):
>   ASoC: hdac_hdmi: parse eld for channel map capability
>   ALSA: hda - add helper to get channels from cap bits
>   ASoC: hdac_hdmi: Add multichannel support
>   ASoC: skl_rt286: Fix to support hdmi channel map support
>   ASoC: Intel: boards: Update skl_nau88l25_max98357a driver to support
>     chmap
>   ASoC: Intel: boards: Update skl_nau88l25_ssm4567 driver to support
>     chmap
>   ASoC: hdac_hdmi: Register chmap controls and ops
>   ASoC: Intel: Skylake: Add multichannel support for HDMI
>   ASoC: Intel: Skylake: Update channel map based on runtime params
> 
>  sound/hda/local.h                               |  10 ++
>  sound/soc/codecs/hdac_hdmi.c                    | 163 ++++++++++++++++++++++--
>  sound/soc/intel/boards/skl_nau88l25_max98357a.c |  74 ++++++++++-
>  sound/soc/intel/boards/skl_nau88l25_ssm4567.c   |  73 ++++++++++-
>  sound/soc/intel/boards/skl_rt286.c              |  48 ++++++-
>  sound/soc/intel/skylake/skl-pcm.c               |  14 +-
>  sound/soc/intel/skylake/skl-topology.c          |  21 ++-
>  7 files changed, 379 insertions(+), 24 deletions(-)
> 
> -- 
> 1.9.1
> 

-- 