All of lore.kernel.org
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: ian.jackson@citrix.com, xen-devel@lists.xensource.com,
	Sjoer van der Ploeg <sfjuocekr@gmail.com>
Subject: Re: QEMU-TRAD Re: [PATCH] Fixed building with newer GNUTLS versions.
Date: Tue, 3 May 2016 12:49:07 -0400	[thread overview]
Message-ID: <20160503164907.GB31399@char.us.oracle.com> (raw)
In-Reply-To: <20160503163545.GB2111@citrix.com>

On Tue, May 03, 2016 at 05:35:45PM +0100, Wei Liu wrote:
> The original patch seems to malformed.
> 
> I skim the code, the refactoring parts look correct to me. What I'm not
> sure is whether the replacement is correct or not.
> 
> The reference to gnutls_priority_set_direct in [0] is from a section
> called "Upgrading to 3.4.x from 3.3.x", while the version check in the
> proposed patch checks for 2.2.0.
> 
> Do I miss anything here? What version does Fedora have?

gnutls-3.4.9-1.fc23.x86_64

qemu-trad builds fine under 
gnutls-2.8.5-4.fc13.x86_64

> 
> Thanks
> Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2016-05-03 16:49 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-31 20:58 [PATCH] Fixed building with newer GNUTLS versions Sjoer van der Ploeg
2016-04-01 13:51 ` QEMU-TRAD " Konrad Rzeszutek Wilk
     [not found]   ` <CAGj-wbF_R7dgRyNyY6ydnvW-P1aV7-rVLfvkH3B_oyf0w0Fy5A@mail.gmail.com>
2016-04-01 16:45     ` Konrad Rzeszutek Wilk
2016-05-03 16:18       ` Konrad Rzeszutek Wilk
2016-05-03 16:35         ` Wei Liu
2016-05-03 16:49           ` Konrad Rzeszutek Wilk [this message]
2016-05-03 16:52             ` Wei Liu
2016-05-04 10:28             ` Wei Liu
2016-05-04 13:06               ` Olaf Hering
2016-05-04 13:29                 ` Wei Liu
2016-05-04 13:38                   ` Olaf Hering
2016-05-04 13:50                     ` Wei Liu
2016-05-04 14:03                       ` Olaf Hering
2016-05-04 14:08                         ` Wei Liu
2016-05-04 14:13                           ` Olaf Hering
2016-05-04 14:16                             ` Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160503164907.GB31399@char.us.oracle.com \
    --to=konrad.wilk@oracle.com \
    --cc=ian.jackson@citrix.com \
    --cc=sfjuocekr@gmail.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.