From: Andrew Jones <drjones@redhat.com>
To: "Radim Krčmář" <rkrcmar@redhat.com>
Cc: kvm@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [kvm-unit-tests PATCH v4 12/13] scripts/arch-run: change QEMU failure detection
Date: Wed, 11 May 2016 19:24:45 +0200 [thread overview]
Message-ID: <20160511172445.bd6tn4cditck3cw6@hawk.localdomain> (raw)
In-Reply-To: <1462984243-5783-3-git-send-email-rkrcmar@redhat.com>
On Wed, May 11, 2016 at 06:30:42PM +0200, Radim Krčmář wrote:
> We FAIL the test whenever there is an output on stderr. QEMU or its
> libraries can warn and the test could still work, so ignore any line
> that has a warning keyword.
>
> Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
> ---
> v4: new
>
> scripts/arch-run.bash | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Andrew Jones <drjones@redhat.com>
>
> diff --git a/scripts/arch-run.bash b/scripts/arch-run.bash
> index 8ef4ff5634a0..8e75c6ed6e17 100644
> --- a/scripts/arch-run.bash
> +++ b/scripts/arch-run.bash
> @@ -55,7 +55,7 @@ run_qemu ()
> # Even when ret==1 (unittest success) if we also got stderr
> # logs, then we assume a QEMU failure. Otherwise we translate
> # status of 1 to 0 (SUCCESS)
> - if [ -z "$errors" ]; then
> + if [ -z "$(echo "$errors" | grep -vi warning)" ]; then
> ret=0
> fi
> fi
> --
> 2.8.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-05-11 17:24 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-11 16:12 [kvm-unit-tests PATCH v4 00/13] Improve the output of test runners Radim Krčmář
2016-05-11 16:12 ` [kvm-unit-tests PATCH v4 01/13] lib/report: allow test skipping Radim Krčmář
2016-05-11 16:12 ` [kvm-unit-tests PATCH v4 02/13] x86/*: report skipped tests Radim Krčmář
2016-05-17 12:19 ` Paolo Bonzini
2016-05-25 17:19 ` Radim Krčmář
2016-05-25 17:23 ` Radim Krčmář
2016-05-26 7:22 ` Paolo Bonzini
2016-05-11 16:12 ` [kvm-unit-tests PATCH v4 03/13] x86/unittests: remove svm-disabled Radim Krčmář
2016-05-11 16:12 ` [kvm-unit-tests PATCH v4 04/13] lib/string: add strncmp Radim Krčmář
2016-05-11 16:33 ` Andrew Jones
2016-05-11 16:12 ` [kvm-unit-tests PATCH v4 05/13] lib/util: add args_parse_keyval Radim Krčmář
2016-05-11 16:58 ` Andrew Jones
2016-05-11 17:19 ` Radim Krčmář
2016-05-11 17:23 ` Andrew Jones
2016-05-11 16:12 ` [kvm-unit-tests PATCH v4 06/13] x86/pmu: expect failure with nmi_watchdog Radim Krčmář
2016-05-11 17:00 ` Andrew Jones
2016-05-11 16:12 ` [kvm-unit-tests PATCH v4 07/13] lib/report: don't print 0 failed tests Radim Krčmář
2016-05-11 16:12 ` [kvm-unit-tests PATCH v4 08/13] scripts/runtime: consolidate summary tags Radim Krčmář
2016-05-17 12:22 ` Paolo Bonzini
2016-05-25 17:46 ` Radim Krčmář
2016-05-11 16:12 ` [kvm-unit-tests PATCH v4 09/13] run_tests: print SUMMARY line in summary Radim Krčmář
2016-05-11 17:10 ` Andrew Jones
2016-05-17 12:32 ` Paolo Bonzini
2016-05-25 17:41 ` Radim Krčmář
2016-05-11 16:30 ` [kvm-unit-tests PATCH v4 10/13] run_tests: log stderr Radim Krčmář
2016-05-11 16:30 ` [kvm-unit-tests PATCH v4 11/13] scripts/runtime: skip tests that cannot run Radim Krčmář
2016-05-11 17:20 ` Andrew Jones
2016-05-11 16:30 ` [kvm-unit-tests PATCH v4 12/13] scripts/arch-run: change QEMU failure detection Radim Krčmář
2016-05-11 17:24 ` Andrew Jones [this message]
2016-05-11 16:30 ` [kvm-unit-tests PATCH v4 13/13] scripts/run: generalize check Radim Krčmář
2016-05-11 17:31 ` Andrew Jones
2016-05-11 17:11 ` [kvm-unit-tests PATCH v4 10/13] run_tests: log stderr Andrew Jones
2016-05-17 12:29 ` [kvm-unit-tests PATCH v4 00/13] Improve the output of test runners Paolo Bonzini
2016-05-25 17:49 ` Radim Krčmář
2016-05-26 7:25 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160511172445.bd6tn4cditck3cw6@hawk.localdomain \
--to=drjones@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.