From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: paul@paul-moore.com, samanthakumar@google.com,
linux-security-module@vger.kernel.org, selinux@tycho.nsa.gov,
netdev@vger.kernel.org, sds@tycho.nsa.gov
Subject: Re: Possible problem with e6afc8ac ("udp: remove headers from UDP packets before queueing")
Date: Thu, 02 Jun 2016 18:31:51 -0400 (EDT) [thread overview]
Message-ID: <20160602.183151.2030076167275348260.davem@davemloft.net> (raw)
In-Reply-To: <1464904363.5939.185.camel@edumazet-glaptop3.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 02 Jun 2016 14:52:43 -0700
> From: Eric Dumazet <edumazet@google.com>
>
> Paul Moore tracked a regression caused by a recent commit, which
> mistakenly assumed that sk_filter() could be avoided if socket
> had no current BPF filter.
>
> The intent was to avoid udp_lib_checksum_complete() overhead.
>
> But sk_filter() also checks skb_pfmemalloc() and
> security_sock_rcv_skb(), so better call it.
>
> Fixes: e6afc8ace6dd ("udp: remove headers from UDP packets before queueing")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Reported-by: Paul Moore <paul@paul-moore.com>
> Tested-by: Paul Moore <paul@paul-moore.com>
> Tested-by: Stephen Smalley <sds@tycho.nsa.gov>
> Cc: samanthakumar <samanthakumar@google.com>
Applied, thanks Eric.
next prev parent reply other threads:[~2016-06-02 22:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-01 19:01 Possible problem with e6afc8ac ("udp: remove headers from UDP packets before queueing") Paul Moore
2016-06-01 19:18 ` Eric Dumazet
[not found] ` <1464808695.5939.167.camel-XN9IlZ5yJG9HTL0Zs8A6p+yfmBU6pStAUsxypvmhUTTZJqsBc5GL+g@public.gmane.org>
2016-06-01 20:44 ` Stephen Smalley
2016-06-01 20:44 ` Stephen Smalley
2016-06-02 21:36 ` Paul Moore
2016-06-02 21:44 ` Eric Dumazet
2016-06-02 21:52 ` Eric Dumazet
2016-06-02 22:31 ` David Miller [this message]
2016-06-03 2:58 ` Eric Dumazet
2016-06-03 4:23 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160602.183151.2030076167275348260.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=linux-security-module@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=samanthakumar@google.com \
--cc=sds@tycho.nsa.gov \
--cc=selinux@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.