From: David Miller <davem@davemloft.net>
To: socketcan@hartkopp.net
Cc: ulrich.hecht@gmail.com, ramesh.shanmugasundaram@bp.renesas.com,
mkl@pengutronix.de, wg@grandegger.com, linux-can@vger.kernel.org,
netdev@vger.kernel.org, Chris.Paterson2@renesas.com,
horms@verge.net.au, magnus.damm@gmail.com,
linux-renesas-soc@vger.kernel.org
Subject: Re: [RESEND PATCH v5 1/2] can: rcar_canfd: Add Renesas R-Car CAN FD driver
Date: Fri, 03 Jun 2016 11:39:02 -0700 (PDT) [thread overview]
Message-ID: <20160603.113902.296916236989519473.davem@davemloft.net> (raw)
In-Reply-To: <5751BB31.5030708@hartkopp.net>
From: Oliver Hartkopp <socketcan@hartkopp.net>
Date: Fri, 3 Jun 2016 19:15:29 +0200
> On 06/03/2016 07:03 PM, Ulrich Hecht wrote:
>
>> Thanks; I missed that every register is described twice.
>>
>> Nevertheless, names often vary more or less subtly between your patch
>> and the specs, making it very hard to review. Some have letters added,
>> some have letters removed, and some are just plain confusing. For
>> instance, RCANFD_DCFG_* apparently does not describe, as one might
>> think, RSCFDnCFDCmDCFG, but RSCFDnCFDCmFDCFG. These names are, of
>> course, completely ridiculous, but inventing a new set makes things
>> even worse, IMO.
>
> ???
>
> You suggest to use 'completely ridiculous' definitions in favor to
> definitions that have a proper name space RCANFD_ ?
>
> When there is a more readable way that maintains proper readable code
> there's no reason to adopt crappy definitions just because some chip
> designer has no clue how to design proper register names.
>
> When there's some mapping from RSCFDnCFDCmFDCFG to RCANFD_DCFG_* this
> could be mentioned in the comments.
>
> But I'm totally against these blurry upper/lower case letter stuff for
> register definitions.
I agree with Oliver, these StuDlyCaPS names used in the spec should
not be used in the driver, they are completely unreadable.
next prev parent reply other threads:[~2016-06-03 18:39 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-01 9:34 [PATCH] can: rcar_canfd: Add Renesas R-Car CAN FD driver Ramesh Shanmugasundaram
[not found] ` <1456824849-7987-1-git-send-email-ramesh.shanmugasundaram-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
2016-03-01 20:41 ` Marc Kleine-Budde
2016-03-01 20:41 ` Marc Kleine-Budde
2016-03-02 8:41 ` Ramesh Shanmugasundaram
2016-03-02 9:20 ` Marc Kleine-Budde
2016-03-02 10:08 ` Ramesh Shanmugasundaram
2016-03-02 10:21 ` Marc Kleine-Budde
2016-03-03 13:48 ` Ramesh Shanmugasundaram
2016-03-01 21:07 ` Oliver Hartkopp
2016-03-02 8:45 ` Ramesh Shanmugasundaram
2016-03-03 15:38 ` [PATCH v2] " Ramesh Shanmugasundaram
2016-03-05 4:30 ` Rob Herring
2016-03-07 9:33 ` Ramesh Shanmugasundaram
2016-03-06 11:32 ` Oliver Hartkopp
2016-03-07 8:02 ` Ramesh Shanmugasundaram
2016-03-07 8:08 ` Marc Kleine-Budde
2016-03-07 8:32 ` Ramesh Shanmugasundaram
2016-03-08 7:46 ` Oliver Hartkopp
2016-03-08 8:57 ` Ramesh Shanmugasundaram
2016-03-08 12:25 ` Oliver Hartkopp
2016-03-08 12:48 ` Ramesh Shanmugasundaram
2016-03-08 17:16 ` Oliver Hartkopp
2016-03-11 7:14 ` Ramesh Shanmugasundaram
2016-03-12 18:49 ` Oliver Hartkopp
2016-03-15 9:48 ` [PATCH v3] " Ramesh Shanmugasundaram
2016-03-15 12:46 ` Oliver Hartkopp
2016-03-15 14:17 ` Ramesh Shanmugasundaram
2016-03-15 19:38 ` Oliver Hartkopp
2016-03-16 7:45 ` Ramesh Shanmugasundaram
2016-03-16 9:47 ` Oliver Hartkopp
2016-03-16 10:50 ` Ramesh Shanmugasundaram
2016-03-16 21:20 ` Oliver Hartkopp
2016-03-17 12:03 ` Ramesh Shanmugasundaram
2016-03-17 20:46 ` Oliver Hartkopp
2016-03-18 13:23 ` Ramesh Shanmugasundaram
2016-03-18 19:44 ` Oliver Hartkopp
2016-03-21 8:30 ` Ramesh Shanmugasundaram
2016-03-21 15:30 ` Oliver Hartkopp
2016-03-21 15:43 ` Ramesh Shanmugasundaram
2016-03-21 15:49 ` Oliver Hartkopp
2016-03-15 12:51 ` Marc Kleine-Budde
2016-03-15 14:26 ` Ramesh Shanmugasundaram
2016-03-18 21:07 ` Rob Herring
2016-03-21 16:45 ` [PATCH v4 0/2] Add CAN FD driver support to r8a7795 SoC Ramesh Shanmugasundaram
2016-03-21 16:45 ` [PATCH 1/2] can: rcar_canfd: Add Renesas R-Car CAN FD driver Ramesh Shanmugasundaram
2016-03-21 16:45 ` [PATCH 2/2] can: rcar_can: Move Renesas CAN driver to rcar dir Ramesh Shanmugasundaram
2016-03-31 20:51 ` [PATCH v2] can: rcar_canfd: Add Renesas R-Car CAN FD driver Marc Kleine-Budde
2016-04-01 12:48 ` Ramesh Shanmugasundaram
2016-04-13 6:25 ` Ramesh Shanmugasundaram
2016-04-28 6:27 ` Oliver Hartkopp
2016-04-28 12:31 ` Ramesh Shanmugasundaram
2016-04-28 12:23 ` [PATCH v5 0/2] Add CAN FD driver support to r8a7795 SoC Ramesh Shanmugasundaram
2016-04-28 12:23 ` [PATCH v5 1/2] can: rcar_canfd: Add Renesas R-Car CAN FD driver Ramesh Shanmugasundaram
2016-05-03 16:47 ` Rob Herring
2016-05-04 6:23 ` Ramesh Shanmugasundaram
2016-04-28 12:23 ` [PATCH v5 2/2] can: rcar_can: Move Renesas CAN driver to rcar dir Ramesh Shanmugasundaram
2016-05-16 15:52 ` [PATCH v5 0/2] Add CAN FD driver support to r8a7795 SoC Chris Paterson
2016-06-02 9:45 ` [RESEND PATCH " Ramesh Shanmugasundaram
2016-06-02 9:45 ` [RESEND PATCH v5 1/2] can: rcar_canfd: Add Renesas R-Car CAN FD driver Ramesh Shanmugasundaram
2016-06-02 16:01 ` Ulrich Hecht
2016-06-03 6:42 ` Ramesh Shanmugasundaram
2016-06-03 17:03 ` Ulrich Hecht
2016-06-03 17:15 ` Oliver Hartkopp
2016-06-03 18:39 ` David Miller [this message]
2016-06-07 13:18 ` Ramesh Shanmugasundaram
2016-06-08 6:38 ` [PATCH v6 0/2] Add CAN FD driver support to r8a7795 SoC Ramesh Shanmugasundaram
2016-06-08 6:38 ` [PATCH v6 1/2] can: rcar_canfd: Add Renesas R-Car CAN FD driver Ramesh Shanmugasundaram
2016-06-13 8:42 ` Ulrich Hecht
2016-06-14 7:23 ` Ramesh Shanmugasundaram
2016-06-08 6:38 ` [PATCH v6 2/2] can: rcar_can: Move Renesas CAN driver to rcar dir Ramesh Shanmugasundaram
2016-06-13 7:12 ` [PATCH v6 0/2] Add CAN FD driver support to r8a7795 SoC Chris Paterson
2016-06-02 9:45 ` [RESEND PATCH v5 2/2] can: rcar_can: Move Renesas CAN driver to rcar dir Ramesh Shanmugasundaram
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160603.113902.296916236989519473.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Chris.Paterson2@renesas.com \
--cc=horms@verge.net.au \
--cc=linux-can@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=ramesh.shanmugasundaram@bp.renesas.com \
--cc=socketcan@hartkopp.net \
--cc=ulrich.hecht@gmail.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.