Re: [PATCH i-g-t 1/2] tests/kms_chv_cursor_fail: Remove extra igt_pipe_crc_start.

From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH i-g-t 1/2] tests/kms_chv_cursor_fail: Remove extra igt_pipe_crc_start.
Date: Wed, 8 Jun 2016 16:14:42 +0300	[thread overview]
Message-ID: <20160608131442.GO4329@intel.com> (raw)
In-Reply-To: <1465385132-17605-1-git-send-email-maarten.lankhorst@linux.intel.com>

On Wed, Jun 08, 2016 at 01:25:31PM +0200, Maarten Lankhorst wrote:
> There is a extra call to igt_pipe_crc_start that is not matched to any
> stop. Because of this the exit handler tries to reset the crc source on
> exit while the pipe disabled. This causes fails with -EIO:
> 
> (kms_chv_cursor_fail:2643) igt-debugfs-CRITICAL: Test assertion failure
> function igt_pipe_crc_pipe_off, file igt_debugfs.c:364:
> (kms_chv_cursor_fail:2643) igt-debugfs-CRITICAL: Failed assertion:
> write(fd, buf, strlen(buf)) == strlen(buf)
> (kms_chv_cursor_fail:2643) igt-debugfs-CRITICAL: Last errno: 5, EIO
> (kms_chv_cursor_fail:2643) igt-debugfs-CRITICAL: error: -1 != 11
> Stack trace:
>   #0 [__igt_fail_assert+0xf1]
>   #1 [igt_pipe_crc_pipe_off+0xe4]
>   #2 [pipe_crc_exit_handler+0x35]
>   #3 [igt_atexit_handler+0x4c]
>   #4 [__libc_secure_getenv+0x112]
>   #5 [exit+0x15]
>   #6 [igt_exit+0xd6]
>   #7 [main+0x1ee]
>   #8 [__libc_start_main+0xf0]
>   #9 [_start+0x29]
>   #10 [<unknown>+0x29]
> 
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> ---
>  tests/kms_chv_cursor_fail.c |   3 -
>  tests/kms_rmfb.c            | 180 ++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 180 insertions(+), 3 deletions(-)
>  create mode 100644 tests/kms_rmfb.c
> 
> diff --git a/tests/kms_chv_cursor_fail.c b/tests/kms_chv_cursor_fail.c
> index 83af07f9b968..11d01f54e511 100644
> --- a/tests/kms_chv_cursor_fail.c
> +++ b/tests/kms_chv_cursor_fail.c
> @@ -163,9 +163,6 @@ static void test_edge_pos(data_t *data, int sx, int ex, int y, bool swap_axis)
>  		}
>  		igt_debug("\n");
>  	}
> -
> -
> -	igt_pipe_crc_start(data->pipe_crc);

ack

>  }
>  
>  static void test_edge(data_t *data, int sy, int ey, int sx, int ex, bool swap_axis)
> diff --git a/tests/kms_rmfb.c b/tests/kms_rmfb.c
> new file mode 100644
> index 000000000000..a3fde9f43788
> --- /dev/null
> +++ b/tests/kms_rmfb.c

git add fail?

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx