From: Christoph Hellwig <hch@infradead.org>
To: Hannes Reinecke <hare@suse.de>
Cc: Ming Lei <ming.lei@canonical.com>, Jens Axboe <axboe@fb.com>,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
Kent Overstreet <kent.overstreet@gmail.com>,
"4.3+" <stable@vger.kernel.org>, Shaohua Li <shli@fb.com>,
Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH v2] block: make sure big bio is splitted into at most 256 bvecs
Date: Mon, 13 Jun 2016 08:46:14 -0700 [thread overview]
Message-ID: <20160613154614.GC23990@infradead.org> (raw)
In-Reply-To: <575AA66D.5010407@suse.de>
On Fri, Jun 10, 2016 at 01:37:17PM +0200, Hannes Reinecke wrote:
> Hmm. So everybody is suffering because someone _might_ be using bio_clone?
> Why can't we fixup bio_clone() (or the callers of which) to correctly
> set the queue limits?
The only one suffering is bcache. Everyone else uses bios below the
block layer arbitrary max size. The fixup to allow bio_clone support
a larger size is the same one as to allow everyone else submitting
larger bios: increase BIO_MAX_PAGES and create the required mempools
to back that new larger size. Or just go for multipage biovecs..
next prev parent reply other threads:[~2016-06-13 15:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-10 11:07 [PATCH v2] block: make sure big bio is splitted into at most 256 bvecs Ming Lei
2016-06-10 11:37 ` Hannes Reinecke
2016-06-10 11:37 ` Hannes Reinecke
2016-06-10 14:16 ` Ming Lei
2016-06-10 14:16 ` Ming Lei
2016-06-13 15:46 ` Christoph Hellwig [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-04-06 3:43 [PATCH v1] " Ming Lei
2016-08-11 6:33 ` [PATCH v2] " Eric Wheeler
2016-08-11 14:02 ` Christoph Hellwig
2016-08-12 11:12 ` Ming Lei
2016-08-12 11:12 ` Ming Lei
2016-08-12 16:36 ` Kent Overstreet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160613154614.GC23990@infradead.org \
--to=hch@infradead.org \
--cc=axboe@fb.com \
--cc=axboe@kernel.dk \
--cc=hare@suse.de \
--cc=kent.overstreet@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@canonical.com \
--cc=shli@fb.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.