From: Kevin O'Connor <kevin@koconnor.net>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: seabios@seabios.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [SeaBIOS] [PATCH 1/3] std: add cp437 to unicode map
Date: Tue, 5 Jul 2016 09:49:02 -0400 [thread overview]
Message-ID: <20160705134902.GA2939@morn.lan> (raw)
In-Reply-To: <1467664794-31002-2-git-send-email-kraxel@redhat.com>
On Mon, Jul 04, 2016 at 10:39:52PM +0200, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Nice!
[...]
> --- /dev/null
> +++ b/src/std/cp437.h
Instead of making a header file and including it in an array in the C
code I think it would be better to instead introduce cp437.c with:
u16 sercon_cp437[256] VARFSEG = {
...
};
[...]
> +[ 0x7f ] = 0x007f, // DELETE
That should be 0x2302 (see the wikipedia page).
-Kevin
next prev parent reply other threads:[~2016-07-05 13:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-04 20:39 [Qemu-devel] [PATCH v2 0/3] seabios: add serial console support Gerd Hoffmann
2016-07-04 20:39 ` [Qemu-devel] [PATCH 1/3] std: add cp437 to unicode map Gerd Hoffmann
2016-07-05 13:49 ` Kevin O'Connor [this message]
2016-07-04 20:39 ` [Qemu-devel] [PATCH 2/3] kbd: make enqueue_key public, add ascii_to_keycode Gerd Hoffmann
2016-07-04 20:39 ` [Qemu-devel] [PATCH 3/3] add serial console support Gerd Hoffmann
2016-07-05 14:30 ` [Qemu-devel] [SeaBIOS] " Kevin O'Connor
2016-07-05 15:07 ` Gerd Hoffmann
2016-07-05 15:23 ` Kevin O'Connor
2016-07-05 8:06 ` [Qemu-devel] [PATCH v2 0/3] seabios: " Daniel P. Berrange
2016-07-05 10:00 ` Gerd Hoffmann
2016-07-05 10:07 ` Daniel P. Berrange
2016-07-05 11:45 ` Paolo Bonzini
2016-07-05 11:59 ` Daniel P. Berrange
2016-07-05 11:15 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160705134902.GA2939@morn.lan \
--to=kevin@koconnor.net \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=seabios@seabios.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.