From: Kevin O'Connor <kevin@koconnor.net>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: seabios@seabios.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [SeaBIOS] [PATCH 1/5] std: add cp437 to unicode map
Date: Thu, 14 Jul 2016 12:17:20 -0400 [thread overview]
Message-ID: <20160714161720.GB28523@morn.lan> (raw)
In-Reply-To: <1468486382-21609-2-git-send-email-kraxel@redhat.com>
On Thu, Jul 14, 2016 at 10:52:58AM +0200, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> Makefile | 5 +-
> src/std/cp437.c | 275 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> src/std/cp437.h | 1 +
> 3 files changed, 279 insertions(+), 2 deletions(-)
> create mode 100644 src/std/cp437.c
> create mode 100644 src/std/cp437.h
>
> diff --git a/Makefile b/Makefile
> index 4930b3a..c11efe6 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -34,7 +34,8 @@ SRCBOTH=misc.c stacks.c output.c string.c block.c cdrom.c disk.c mouse.c kbd.c \
> hw/usb.c hw/usb-uhci.c hw/usb-ohci.c hw/usb-ehci.c \
> hw/usb-hid.c hw/usb-msc.c hw/usb-uas.c \
> hw/blockcmd.c hw/floppy.c hw/ata.c hw/ramdisk.c \
> - hw/lsi-scsi.c hw/esp-scsi.c hw/megasas.c hw/mpt-scsi.c
> + hw/lsi-scsi.c hw/esp-scsi.c hw/megasas.c hw/mpt-scsi.c \
> + std/cp437.c
Lets put this file in src/ instead of src/std/. (I think of std/ as a
location for published BIOS interface standards.)
Otherwise, looks good.
-Kevin
next prev parent reply other threads:[~2016-07-14 16:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-14 8:52 [Qemu-devel] [PATCH 0/5] serial console support Gerd Hoffmann
2016-07-14 8:52 ` [Qemu-devel] [PATCH 1/5] std: add cp437 to unicode map Gerd Hoffmann
2016-07-14 16:17 ` Kevin O'Connor [this message]
2016-07-14 8:52 ` [Qemu-devel] [PATCH 2/5] kbd: make enqueue_key public, add ascii_to_keycode Gerd Hoffmann
2016-07-14 8:53 ` [Qemu-devel] [PATCH 3/5] paravirt: read QEMU_CFG_NOGRAPHIC, store in etc/sercon-enable romfile Gerd Hoffmann
2016-07-14 8:53 ` [Qemu-devel] [PATCH 4/5] add serial console support Gerd Hoffmann
2016-07-14 8:53 ` [Qemu-devel] [PATCH 5/5] [wip] sercon: initial split-output implementation Gerd Hoffmann
2016-07-14 16:15 ` [Qemu-devel] [SeaBIOS] " Kevin O'Connor
2016-07-15 11:49 ` Gerd Hoffmann
2016-07-15 14:35 ` Kevin O'Connor
2016-08-08 13:14 ` Gerd Hoffmann
2016-09-27 12:00 ` Gerd Hoffmann
2016-10-04 3:03 ` Kevin O'Connor
2016-10-04 8:49 ` Gerd Hoffmann
2016-10-04 9:21 ` Igor Mammedov
2016-10-13 7:17 ` Gerd Hoffmann
2016-10-13 8:09 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160714161720.GB28523@morn.lan \
--to=kevin@koconnor.net \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=seabios@seabios.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.