From: Chris Wilson <chris@chris-wilson.co.uk>
To: David Herrmann <dh.herrmann@gmail.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
DRI Development <dri-devel@lists.freedesktop.org>,
Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH 1/2] drm: Mark up legacy/dri1 drivers with DRM_LEGACY
Date: Thu, 4 Aug 2016 08:37:22 +0100 [thread overview]
Message-ID: <20160804073722.GJ12611@nuc-i3427.alporthouse.com> (raw)
In-Reply-To: <CANq1E4Sm0pUQRH8AASxW+528JZ3=0vhwkBFz-Db69EwiHK19qw@mail.gmail.com>
On Thu, Aug 04, 2016 at 09:32:01AM +0200, David Herrmann wrote:
> Hi
>
> On Wed, Aug 3, 2016 at 9:11 PM, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> > It's super confusing that new drivers need to be marked with
> > DRIVER_MODESET when really it means DRIVER_MODERN. Much better to
> > invert the meaning and rename it to something that's suitably
> > off-putting.
> >
> > Since there's over 100 places using DRIVER_MODESET we need to roll out
> > this change without a flag day.
> >
> > v2: Update docs.
> >
> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> > ---
> > Documentation/gpu/drm-internals.rst | 9 ++++++---
> > drivers/gpu/drm/i810/i810_drv.c | 4 +---
> > drivers/gpu/drm/mga/mga_drv.c | 2 +-
> > drivers/gpu/drm/r128/r128_drv.c | 2 +-
> > drivers/gpu/drm/savage/savage_drv.c | 2 +-
> > drivers/gpu/drm/sis/sis_drv.c | 2 +-
> > drivers/gpu/drm/tdfx/tdfx_drv.c | 1 +
> > drivers/gpu/drm/via/via_drv.c | 2 +-
> > include/drm/drmP.h | 1 +
> > 9 files changed, 14 insertions(+), 11 deletions(-)
>
> Reviewed-by: David Herrmann <dh.herrmann@gmail.com>
>
> Also, how about this:
config DRM_LEGACY
bool "Enable legacy drivers (DANGEROUS)"
depends on DRM
depends on BROKEN
help
...
Then everyone else gets depends on DRM_LEGACY. The benefit is that we
get the chance to add a useful help message and hopefully explains the
situation more cleary to devs.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2016-08-04 7:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-03 19:11 [PATCH 1/2] drm: Mark up legacy/dri1 drivers with DRM_LEGACY Daniel Vetter
2016-08-03 19:11 ` [PATCH 2/2] drm: Used DRM_LEGACY for all legacy functions Daniel Vetter
2016-08-04 7:37 ` David Herrmann
2016-08-04 7:37 ` Frank Binns
2016-08-04 8:20 ` Daniel Vetter
2016-08-04 8:36 ` Frank Binns
2016-08-04 9:01 ` Daniel Vetter
2016-08-04 7:22 ` [PATCH 1/2] drm: Mark up legacy/dri1 drivers with DRM_LEGACY Frank Binns
2016-08-04 7:32 ` David Herrmann
2016-08-04 7:37 ` Chris Wilson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160804073722.GJ12611@nuc-i3427.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dh.herrmann@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.