From: Carlos Maiolino <cmaiolino@redhat.com>
To: Dave Chinner <david@fromorbit.com>
Cc: linux-xfs@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH] [RFC] xfs: make xfs btree stats less huge
Date: Tue, 13 Sep 2016 11:06:57 +0200 [thread overview]
Message-ID: <20160913090657.gz75xuhjhb6645sd@redhat.com> (raw)
In-Reply-To: <1473755322-883-1-git-send-email-david@fromorbit.com>
On Tue, Sep 13, 2016 at 06:28:42PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> Embedding a switch statement in every btree stats inc/add adds a lot
> of code overhead to the core btree infrastructure paths. Stats are
> supposed to be small and lightweight, but the btree stats have
> become big and bloated as we've added more btrees. It needs fixing
> because the reflink code will just add more overhead again.
Talking about stats, is there any documentation for that? I was using the log
stats while working on the fail_at_unmount hang, and I couldn't find anything
other than looking into the code to see what each number means.
Cheers
--
Carlos
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-09-13 9:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-13 8:28 [PATCH] [RFC] xfs: make xfs btree stats less huge Dave Chinner
2016-09-13 9:06 ` Carlos Maiolino [this message]
2016-09-13 21:15 ` Dave Chinner
2016-09-19 23:49 ` Dave Chinner
2016-09-20 4:16 ` Darrick J. Wong
2016-09-20 5:59 ` Dave Chinner
2016-09-20 6:10 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160913090657.gz75xuhjhb6645sd@redhat.com \
--to=cmaiolino@redhat.com \
--cc=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.