From: Simon Horman <horms@verge.net.au>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>,
Ulf Hansson <ulf.hansson@linaro.org>
Cc: Magnus Damm <magnus.damm@gmail.com>,
linux-mmc@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
Ai Kyuse <ai.kyuse.uw@renesas.com>
Subject: Re: [PATCH v7 6/6] mmc: sh_mobile_sdhi: Add tuning support
Date: Wed, 14 Sep 2016 10:53:11 +0200 [thread overview]
Message-ID: <20160914085311.GC10233@verge.net.au> (raw)
In-Reply-To: <1473764175-24580-7-git-send-email-horms+renesas@verge.net.au>
On Tue, Sep 13, 2016 at 12:56:15PM +0200, Simon Horman wrote:
> Add tuning support for use with SDR104 mode
> This includes adding support for the sampling clock controller (SCC).
>
> Based on work by Ai Kyuse.
>
> Cc: Ai Kyuse <ai.kyuse.uw@renesas.com>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
...
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> ---
> drivers/mmc/host/sh_mobile_sdhi.c | 265 +++++++++++++++++++++++++++++++++++++-
> 1 file changed, 264 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sh_mobile_sdhi.c b/drivers/mmc/host/sh_mobile_sdhi.c
> index 49edff7fee49..32d3e01e0840 100644
> --- a/drivers/mmc/host/sh_mobile_sdhi.c
> +++ b/drivers/mmc/host/sh_mobile_sdhi.c
...
> +static void sh_mobile_sdhi_hw_reset(struct tmio_mmc_host *host)
> +{
> + struct sh_mobile_sdhi *priv;
> +
> + if (host->mmc->caps & MMC_CAP_UHS_SDR104)
> + return;
The logic above is inverted, it should be:
if (!(host->mmc->caps & MMC_CAP_UHS_SDR104))
return;
An observable side effect of the above is that on the r8a7796/Salvator-X
a card is not detected after being ejected and re-inserted.
next prev parent reply other threads:[~2016-09-14 8:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-13 10:56 [PATCH v7 0/6] UHS-I SDR-104 support for sh_mobile_sdhi Simon Horman
2016-09-13 10:56 ` [PATCH v7 1/6] mmc: core: Add helper to see if a host can be retuned Simon Horman
2016-09-13 10:56 ` [PATCH v7 2/6] mmc: tmio: enhance illegal sequence handling Simon Horman
2016-09-13 10:56 ` [PATCH v7 3/6] mmc: tmio: document mandatory and optional callbacks Simon Horman
2016-09-13 10:56 ` [PATCH v7 4/6] mmc: tmio: Add hw reset support Simon Horman
2016-09-13 10:56 ` [PATCH v7 5/6] mmc: tmio: Add tuning support Simon Horman
2016-09-13 10:56 ` [PATCH v7 6/6] mmc: sh_mobile_sdhi: " Simon Horman
2016-09-14 8:53 ` Simon Horman [this message]
2016-09-13 12:48 ` [PATCH v7 0/6] UHS-I SDR-104 support for sh_mobile_sdhi Ulf Hansson
2016-09-13 12:58 ` Wolfram Sang
2016-09-14 8:54 ` Simon Horman
2016-09-14 16:04 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160914085311.GC10233@verge.net.au \
--to=horms@verge.net.au \
--cc=ai.kyuse.uw@renesas.com \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=ulf.hansson@linaro.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.