From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: linux-xfs@vger.kernel.org, Chris Murphy <chris@cmurf.com>,
xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] mkfs.xfs: clarify ftype defaults in manpage
Date: Mon, 19 Sep 2016 12:16:04 +1000 [thread overview]
Message-ID: <20160919021604.GA340@dastard> (raw)
In-Reply-To: <1f98ea1d-893c-d1c0-2307-3f5a9b478238@redhat.com>
On Fri, Sep 16, 2016 at 03:48:14PM -0500, Eric Sandeen wrote:
> When CRCs were made default, a few leftovers related to its
> prior non-default status remained in the manpage, in the ftype
> section. Clean those up.
>
> Reported-by: Chris Murphy <chris@cmurf.com>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
>
> diff --git a/man/man8/mkfs.xfs.8 b/man/man8/mkfs.xfs.8
> index 9578c4d..033bc36 100644
> --- a/man/man8/mkfs.xfs.8
> +++ b/man/man8/mkfs.xfs.8
> @@ -636,13 +636,13 @@ do not need to look up the inode to determine the inode type.
>
> The
> .I value
> -is either 0 or 1, with 1 signifiying that filetype information
> -will be stored in the directory structure. The default value is 0.
> +is either 0 or 1, with 1 signifying that filetype information
> +will be stored in the directory structure.
>
> -When CRCs are enabled via
> -.B \-m crc=1,
> -the ftype functionality is always enabled. This feature can not be turned
> -off for such filesystem configurations.
> +When CRCs are enabled (the default), the ftype functionality is always
> +enabled, and cannot be turned off. If CRCs are disabled with
> +.B \-m crc=0,
> +the ftype functionality is disabled by default.
I think that's wrong:
$ sudo mkfs.xfs -f -m crc=0 /dev/vda
....
naming =version 2 bsize=4096 ascii-ci=0 ftype=1
^^^^^^^
i.e. ftype is enabled by default for all configurations these days.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-09-19 2:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-16 20:48 [PATCH] mkfs.xfs: clarify ftype defaults in manpage Eric Sandeen
2016-09-19 2:16 ` Dave Chinner [this message]
2016-09-19 12:44 ` Eric Sandeen
2016-09-19 13:26 ` [PATCH V2] " Eric Sandeen
2016-09-25 14:35 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160919021604.GA340@dastard \
--to=david@fromorbit.com \
--cc=chris@cmurf.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.