From: Christoph Hellwig <hch@infradead.org>
To: Jens Axboe <axboe@fb.com>
Cc: axboe@kernel.dk, linux-block@vger.kernel.org, jbacik@fb.com
Subject: Re: [PATCH 1/2] blk-mq: get rid of manual run of queue with __blk_mq_run_hw_queue()
Date: Thu, 22 Sep 2016 07:56:57 -0700 [thread overview]
Message-ID: <20160922145657.GA1800@infradead.org> (raw)
In-Reply-To: <1474555980-2787-2-git-send-email-axboe@fb.com>
On Thu, Sep 22, 2016 at 08:52:59AM -0600, Jens Axboe wrote:
> Two cases:
>
> 1) blk_mq_alloc_request() needlessly re-runs the queue, after
> calling into the tag allocation without NOWAIT set. We don't
> need to do that.
>
> 2) blk_mq_map_request() should just use blk_mq_run_hw_queue() with
> the async flag set to false.
I had some very similar patches in my queue but never got around
benchmarking them in enough setups to feel safe enough to post them.
Assuming you found no reaosn to keep the odd old scheme either:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2016-09-22 14:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-22 14:52 [PATCH 0/2]: Add option for async ->queue_rq Jens Axboe
2016-09-22 14:52 ` [PATCH 1/2] blk-mq: get rid of manual run of queue with __blk_mq_run_hw_queue() Jens Axboe
2016-09-22 14:56 ` Christoph Hellwig [this message]
2016-09-22 18:56 ` Christoph Hellwig
2016-09-22 20:29 ` Jens Axboe
2016-09-23 21:59 ` Sagi Grimberg
2016-09-23 21:56 ` Sagi Grimberg
2016-09-22 14:53 ` [PATCH 2/2] blk-mq: add flag for drivers wanting blocking ->queue_rq() Jens Axboe
2016-09-22 14:59 ` Christoph Hellwig
2016-09-22 15:03 ` Jens Axboe
2016-09-22 15:12 ` Christoph Hellwig
2016-09-22 15:17 ` Jens Axboe
2016-09-23 1:43 ` Ming Lei
2016-09-23 2:44 ` Josef Bacik
2016-09-23 1:35 ` Ming Lei
2016-09-22 15:04 ` Josef Bacik
2016-09-22 18:01 ` [PATCH 0/2]: Add option for async ->queue_rq Josef Bacik
2016-09-28 0:25 ` Bart Van Assche
2016-09-28 16:43 ` Omar Sandoval
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160922145657.GA1800@infradead.org \
--to=hch@infradead.org \
--cc=axboe@fb.com \
--cc=axboe@kernel.dk \
--cc=jbacik@fb.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.