From: "J. Bruce Fields" <bfields@fieldses.org>
To: Jeff Layton <jlayton@redhat.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH] nfsd: fix dprintk in nfsd4_encode_getdeviceinfo
Date: Thu, 22 Sep 2016 12:12:36 -0400 [thread overview]
Message-ID: <20160922161236.GG30401@fieldses.org> (raw)
In-Reply-To: <1474543142-3534-1-git-send-email-jlayton@redhat.com>
On Thu, Sep 22, 2016 at 07:19:02AM -0400, Jeff Layton wrote:
> nfserr is big-endian, so we should convert it to host-endian before
> printing it.
Thanks, applying.--b.
>
> Signed-off-by: Jeff Layton <jlayton@redhat.com>
> ---
> fs/nfsd/nfs4xdr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c
> index 0aa0236a1429..7f8232e32dc7 100644
> --- a/fs/nfsd/nfs4xdr.c
> +++ b/fs/nfsd/nfs4xdr.c
> @@ -4062,7 +4062,7 @@ nfsd4_encode_getdeviceinfo(struct nfsd4_compoundres *resp, __be32 nfserr,
> u32 starting_len = xdr->buf->len, needed_len;
> __be32 *p;
>
> - dprintk("%s: err %d\n", __func__, nfserr);
> + dprintk("%s: err %d\n", __func__, be32_to_cpu(nfserr));
> if (nfserr)
> goto out;
>
> --
> 2.7.4
prev parent reply other threads:[~2016-09-22 16:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-22 11:19 [PATCH] nfsd: fix dprintk in nfsd4_encode_getdeviceinfo Jeff Layton
2016-09-22 16:12 ` J. Bruce Fields [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160922161236.GG30401@fieldses.org \
--to=bfields@fieldses.org \
--cc=jlayton@redhat.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.