From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Abdiel Janulgue <abdiel.janulgue@linux.intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 3/3] igt/kms_flip: Use new igt_spin_batch
Date: Fri, 28 Oct 2016 19:02:28 +0300 [thread overview]
Message-ID: <20161028160228.GJ4617@intel.com> (raw)
In-Reply-To: <20161028154726.17512-4-abdiel.janulgue@linux.intel.com>
On Fri, Oct 28, 2016 at 06:47:26PM +0300, Abdiel Janulgue wrote:
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Signed-off-by: Abdiel Janulgue <abdiel.janulgue@linux.intel.com>
> ---
> tests/kms_flip.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/kms_flip.c b/tests/kms_flip.c
> index 9829b35..13cb262 100644
> --- a/tests/kms_flip.c
> +++ b/tests/kms_flip.c
> @@ -866,10 +866,10 @@ static unsigned int run_test_step(struct test_output *o)
> o->current_fb_id = !o->current_fb_id;
>
> if (o->flags & TEST_WITH_DUMMY_BCS)
> - emit_dummy_load__bcs(o, 1);
> + igt_spin_batch_wait(drm_fd, 1, I915_EXEC_BLT);
>
> if (o->flags & TEST_WITH_DUMMY_RCS)
> - emit_dummy_load__rcs(o, 1);
> + igt_spin_batch_wait(drm_fd, 1, I915_EXEC_RENDER);
NAK That's not going to add the required dependency between the load
and the bo used by the test.
>
> if (o->flags & TEST_FB_RECREATE)
> recreate_fb(o);
> --
> 2.7.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-10-28 16:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-28 15:47 [RFC v2 i-g-t] Auto-tuned dummyload + recursive batch Abdiel Janulgue
2016-10-28 15:47 ` [PATCH 1/3] lib: add igt_dummyload Abdiel Janulgue
2016-10-28 15:47 ` [PATCH 2/3] igt/gem_wait: Use new igt_spin_batch Abdiel Janulgue
2016-10-28 15:47 ` [PATCH 3/3] igt/kms_flip: " Abdiel Janulgue
2016-10-28 16:02 ` Ville Syrjälä [this message]
2016-10-31 6:43 ` Abdiel Janulgue
2016-11-03 9:40 ` [PATCH v3 1/3] lib: add igt_dummyload Abdiel Janulgue
2016-11-03 9:40 ` [PATCH v3 2/3] igt/gem_wait: Use new igt_spin_batch Abdiel Janulgue
2016-11-03 9:40 ` [PATCH v3 3/3] igt/kms_flip: " Abdiel Janulgue
2016-11-03 14:38 ` [PATCH v3 1/3] lib: add igt_dummyload Ville Syrjälä
2016-11-04 7:57 ` Abdiel Janulgue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161028160228.GJ4617@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=abdiel.janulgue@linux.intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.