Re: [PATCH] uvcvideo: Add bayer 16-bit format patterns

From: Sakari Ailus <sakari.ailus@iki.fi>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Edgar Thier <info@edgarthier.net>, linux-media@vger.kernel.org
Subject: Re: [PATCH] uvcvideo: Add bayer 16-bit format patterns
Date: Tue, 15 Nov 2016 19:04:02 +0200	[thread overview]
Message-ID: <20161115170402.GY3217@valkosipuli.retiisi.org.uk> (raw)
In-Reply-To: <1640565.qtzjRM8HWd@avalon>

Hi Laurent,

On Tue, Nov 15, 2016 at 04:44:04PM +0200, Laurent Pinchart wrote:
> Hi Sakari,
> 

...

> > +Description
> > +===========
> > +
> > +These four pixel formats are raw sRGB / Bayer formats with 16 bits per
> > +sample. Each sample is stored in a 16-bit word. Each n-pixel row contains
> > +n/2 green samples and n/2 blue or red samples, with alternating red and
> > blue
> > +rows. Bytes are stored in memory in little endian order. They are
> > +conventionally described as GRGR... BGBG..., RGRG... GBGB..., etc. Below
> > is
> > +an example of one of these formats:
> 
> To make it clearer, how about telling which format that is ?

I don't object the change as such, but the text is the same than on other
bayer formats as well. The fix should not be done on this one only.

I propose to handle that separately if that's ok for you.

-- 
Regards,

Sakari Ailus
e-mail: sakari.ailus@iki.fi	XMPP: sailus@retiisi.org.uk