From: David Sterba <dsterba@suse.cz>
To: Omar Sandoval <osandov@osandov.com>
Cc: Tsutomu Itoh <t-itoh@jp.fujitsu.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs-progs: send: fix failure of xfstests btrfs/038
Date: Fri, 18 Nov 2016 18:55:09 +0100 [thread overview]
Message-ID: <20161118175509.GB12522@twin.jikos.cz> (raw)
In-Reply-To: <20161117192441.GA5272@vader.DHCP.thefacebook.com>
On Thu, Nov 17, 2016 at 11:24:41AM -0800, Omar Sandoval wrote:
> On Tue, Nov 15, 2016 at 05:16:27PM +0900, Tsutomu Itoh wrote:
> > The following patch was imperfect, so xfstests btrfs/038 was failed.
> >
> > 6d4fb3d btrfs-progs: send: fix handling of multiple snapshots (-p option)
> >
> > [before]
> > | # ./check btrfs/038
> > | FSTYP -- btrfs
> > | PLATFORM -- Linux/x86_64 luna 4.9.0-rc5
> > | MKFS_OPTIONS -- /dev/sdb3
> > | MOUNT_OPTIONS -- /dev/sdb3 /test6
> > |
> > | btrfs/038 1s ... [failed, exit status 1] - output mismatch (see /For_RT/xfstests2/results//btrfs/038.out.bad)
> > | --- tests/btrfs/038.out 2015-08-04 16:09:38.000000000 +0900
> > | +++ /For_RT/xfstests2/results//btrfs/038.out.bad 2016-11-15 13:39:48.589435290 +0900
> > | @@ -7,3 +7,5 @@
> > | XXX Bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
> > | wrote 10000/10000 bytes at offset 300000
> > | XXX Bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
> > | +failed: '/usr/local/bin/btrfs send -p /test6/mysnap1 -c /test6/clones_snap /test6/mysnap2 -f /tmp/tmp.aLpvAC7lsx/2.snap'
> > | +(see /For_RT/xfstests2/results//btrfs/038.full for details)
> > | ...
> > | (Run 'diff -u tests/btrfs/038.out /For_RT/xfstests2/results//btrfs/038.out.bad' to see the entire diff)
> > | Ran: btrfs/038
> > | Failures: btrfs/038
> >
> > [after]
> > | # ./check btrfs/038
> > | FSTYP -- btrfs
> > | PLATFORM -- Linux/x86_64 luna 4.9.0-rc5
> > | MKFS_OPTIONS -- /dev/sdb3
> > | MOUNT_OPTIONS -- /dev/sdb3 /test6
> > |
> > | btrfs/038 1s ... 1s
> > | Ran: btrfs/038
> > | Passed all 1 tests
> >
> > Signed-off-by: Tsutomu Itoh <t-itoh@jp.fujitsu.com>
>
> Verified that this fixes both btrfs/038 and btrfs/117.
>
> Tested-by: Omar Sandoval <osandov@fb.com>
Applied, thanks.
prev parent reply other threads:[~2016-11-18 17:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-15 8:16 [PATCH] btrfs-progs: send: fix failure of xfstests btrfs/038 Tsutomu Itoh
2016-11-17 19:24 ` Omar Sandoval
2016-11-18 17:55 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161118175509.GB12522@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=osandov@osandov.com \
--cc=t-itoh@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.