From: David Sterba <dsterba@suse.cz>
To: Jeff Mahoney <jeffm@suse.com>
Cc: Omar Sandoval <osandov@osandov.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 1/2] btrfs: remove old tree_root dirent processing in btrfs_real_readdir()
Date: Mon, 21 Nov 2016 16:02:49 +0100 [thread overview]
Message-ID: <20161121150249.GI12522@twin.jikos.cz> (raw)
In-Reply-To: <5953d956-1ff1-6635-f593-12da1c31b36e@suse.com>
On Mon, Nov 14, 2016 at 09:08:14PM -0500, Jeff Mahoney wrote:
> >> - */
> >> - if (location.type == BTRFS_ROOT_ITEM_KEY &&
> >> - location.objectid == root->root_key.objectid) {
> >> - over = 0;
> >> - goto skip;
> >> - }
> >> - over = !dir_emit(ctx, name_ptr, name_len,
> >> - location.objectid, d_type);
> >> + over = !dir_emit(ctx, name_ptr, name_len, location.objectid,
> >> + d_type);
> >>
> >> -skip:
> >> - if (name_ptr != tmp_name)
> >> - kfree(name_ptr);
> >> + if (name_ptr != tmp_name)
> >> + kfree(name_ptr);
> >>
> >> - if (over)
> >> - goto nopos;
> >> - emitted = true;
> >
> > Shouldn't this line (getting rid of emitted) be in the next patch?
>
> Yep. Good catch.
Updated.
prev parent reply other threads:[~2016-11-21 15:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-05 17:26 [PATCH 1/2] btrfs: remove old tree_root dirent processing in btrfs_real_readdir() jeffm
2016-11-05 17:26 ` [PATCH 2/2] btrfs: increment ctx->pos for every emitted or skipped dirent in readdir jeffm
2016-11-11 11:37 ` David Sterba
2016-11-11 10:44 ` [PATCH 1/2] btrfs: remove old tree_root dirent processing in btrfs_real_readdir() David Sterba
2016-11-11 16:05 ` Omar Sandoval
2016-11-15 2:08 ` Jeff Mahoney
2016-11-21 15:02 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161121150249.GI12522@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=jeffm@suse.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=osandov@osandov.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.